Skip to content

Commit 860f2d5

Browse files
committed
refactor: remove redundant tests for send_message without extensions in JsonRpc and Rest transports
1 parent 17d30a4 commit 860f2d5

File tree

2 files changed

+0
-65
lines changed

2 files changed

+0
-65
lines changed

tests/client/test_jsonrpc_client.py

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -898,38 +898,6 @@ async def test_send_message_with_extensions(
898898
expected_extensions = {'test_extension_1', 'test_extension_2'}
899899
assert actual_extensions == expected_extensions
900900

901-
@pytest.mark.asyncio
902-
async def test_send_message_no_extensions(
903-
self, mock_httpx_client: AsyncMock, mock_agent_card: MagicMock
904-
):
905-
"""Test that send_message does not add extension headers when client_extensions is None."""
906-
client = JsonRpcTransport(
907-
httpx_client=mock_httpx_client,
908-
client_extensions=None,
909-
agent_card=mock_agent_card,
910-
)
911-
params = MessageSendParams(
912-
message=create_text_message_object(content='Hello')
913-
)
914-
success_response = create_text_message_object(
915-
role=Role.agent, content='Hi there!'
916-
)
917-
rpc_response = SendMessageSuccessResponse(
918-
id='123', jsonrpc='2.0', result=success_response
919-
)
920-
# Mock the response from httpx_client.post
921-
mock_response = AsyncMock(spec=httpx.Response)
922-
mock_response.status_code = 200
923-
mock_response.json.return_value = rpc_response.model_dump(mode='json')
924-
mock_httpx_client.post.return_value = mock_response
925-
926-
await client.send_message(request=params)
927-
928-
mock_httpx_client.post.assert_called_once()
929-
_, mock_kwargs = mock_httpx_client.post.call_args
930-
headers = mock_kwargs.get('headers', {})
931-
assert HTTP_EXTENSION_HEADER not in headers
932-
933901
@pytest.mark.asyncio
934902
@patch('a2a.client.transports.jsonrpc.aconnect_sse')
935903
async def test_send_message_streaming_with_extensions(

tests/client/test_rest_client.py

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -116,39 +116,6 @@ async def test_send_message_with_extensions(
116116
expected_extensions = {'test_extension_1', 'test_extension_2'}
117117
assert actual_extensions == expected_extensions
118118

119-
@pytest.mark.asyncio
120-
async def test_send_message_no_extensions(
121-
self, mock_httpx_client: AsyncMock, mock_agent_card: MagicMock
122-
):
123-
"""Test that send_message does not add extension headers when client_extensions is None."""
124-
client = RestTransport(
125-
httpx_client=mock_httpx_client,
126-
client_extensions=None,
127-
agent_card=mock_agent_card,
128-
)
129-
params = MessageSendParams(
130-
message=create_text_message_object(content='Hello')
131-
)
132-
133-
# Mock the build_request method to capture its inputs
134-
mock_build_request = MagicMock(
135-
return_value=AsyncMock(spec=httpx.Request)
136-
)
137-
mock_httpx_client.build_request = mock_build_request
138-
139-
# Mock the send method
140-
mock_response = AsyncMock(spec=httpx.Response)
141-
mock_response.status_code = 200
142-
mock_httpx_client.send.return_value = mock_response
143-
144-
await client.send_message(request=params)
145-
146-
mock_build_request.assert_called_once()
147-
_, kwargs = mock_build_request.call_args
148-
149-
headers = kwargs.get('headers', {})
150-
assert HTTP_EXTENSION_HEADER not in headers
151-
152119
@pytest.mark.asyncio
153120
@patch('a2a.client.transports.rest.aconnect_sse')
154121
async def test_send_message_streaming_with_extensions(

0 commit comments

Comments
 (0)