Skip to content

Commit f834fa2

Browse files
committed
fix: type issues
1 parent 3cb0f71 commit f834fa2

File tree

12 files changed

+45
-39
lines changed

12 files changed

+45
-39
lines changed

src/a2a/server/tasks/__init__.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,17 @@
22

33
import logging
44

5-
from a2a.server.tasks.base_push_notification_sender import (
5+
from a2a.server.tasks import (
66
BasePushNotificationSender,
7-
)
8-
from a2a.server.tasks.inmemory_push_notification_config_store import (
97
InMemoryPushNotificationConfigStore,
10-
)
11-
from a2a.server.tasks.inmemory_task_store import InMemoryTaskStore
12-
from a2a.server.tasks.push_notification_config_store import (
8+
InMemoryTaskStore,
139
PushNotificationConfigStore,
10+
PushNotificationSender,
11+
ResultAggregator,
12+
TaskManager,
13+
TaskStore,
14+
TaskUpdater,
1415
)
15-
from a2a.server.tasks.push_notification_sender import PushNotificationSender
16-
from a2a.server.tasks.result_aggregator import ResultAggregator
17-
from a2a.server.tasks.task_manager import TaskManager
18-
from a2a.server.tasks.task_store import TaskStore
19-
from a2a.server.tasks.task_updater import TaskUpdater
2016

2117

2218
logger = logging.getLogger(__name__)

tests/client/test_auth_middleware.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
ClientFactory,
1818
InMemoryContextCredentialStore,
1919
)
20-
from a2a.client.auth.credentials import InMemoryContextCredentialStore
2120
from a2a.types import (
2221
APIKeySecurityScheme,
2322
AgentCapabilities,

tests/client/test_base_client.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ def sample_message() -> Message:
4747

4848

4949
@pytest.fixture
50-
def base_client(sample_agent_card: AgentCard, mock_transport: AsyncMock):
50+
def base_client(
51+
sample_agent_card: AgentCard, mock_transport: AsyncMock
52+
) -> BaseClient:
5153
config = ClientConfig(streaming=True)
5254
return BaseClient(
5355
card=sample_agent_card,

tests/server/agent_execution/test_context.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def test_get_user_input_no_params(self):
106106
context = RequestContext()
107107
assert context.get_user_input() == ''
108108

109-
def test_attach_related_task(self, mock_task: Mock):
109+
def test_attach_related_task(self, mock_task: Mock) -> None:
110110
"""Test attach_related_task adds a task to related_tasks."""
111111
context = RequestContext()
112112
assert len(context.related_tasks) == 0
@@ -257,7 +257,7 @@ def test_metadata_property_with_content(self, mock_params: Mock) -> None:
257257
assert context.metadata == {'key': 'value'}
258258

259259
def test_init_with_existing_ids_in_message(
260-
self, mock_message, mock_params
260+
self, mock_message: Mock, mock_params: Mock
261261
) -> None:
262262
"""Test initialization with existing IDs in the message."""
263263
mock_message.task_id = 'existing-task-id'
@@ -270,7 +270,7 @@ def test_init_with_existing_ids_in_message(
270270
# No new UUIDs should be generated
271271

272272
def test_init_with_task_id_and_existing_task_id_match(
273-
self, mock_params: Mock, mock_task
273+
self, mock_params: Mock, mock_task: Mock
274274
) -> None:
275275
"""Test initialization succeeds when task_id matches task.id."""
276276
mock_params.message.task_id = mock_task.id

tests/server/agent_execution/test_simple_request_context_builder.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,25 @@
2626

2727
# Helper to create a simple message
2828
def create_sample_message(
29-
content='test message',
30-
msg_id='msg1',
31-
role=Role.user,
32-
reference_task_ids=None,
33-
):
29+
content: str = 'test message',
30+
msg_id: str = 'msg1',
31+
role: Role = Role.user,
32+
reference_task_ids: list[str] | None = None,
33+
) -> Message:
3434
return Message(
3535
message_id=msg_id,
3636
role=role,
3737
parts=[Part(root=TextPart(text=content))],
38-
referenceTaskIds=reference_task_ids if reference_task_ids else [],
38+
reference_task_ids=reference_task_ids if reference_task_ids else [],
3939
)
4040

4141

4242
# Helper to create a simple task
4343
def create_sample_task(
44-
task_id='task1', status_state=TaskState.submitted, context_id='ctx1'
45-
):
44+
task_id: str = 'task1',
45+
status_state: TaskState = TaskState.submitted,
46+
context_id: str = 'ctx1',
47+
) -> Task:
4648
return Task(
4749
id=task_id,
4850
context_id=context_id,

tests/server/events/test_inmemory_queue_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def event_queue(self) -> MagicMock:
2828
return queue
2929

3030
@pytest.mark.asyncio
31-
async def test_init(self, queue_manager: InMemoryQueueManager):
31+
async def test_init(self, queue_manager: InMemoryQueueManager) -> None:
3232
"""Test that the InMemoryQueueManager initializes with empty task queue and a lock."""
3333
assert queue_manager._task_queue == {}
3434
assert isinstance(queue_manager._lock, asyncio.Lock)

tests/server/request_handlers/test_response_helpers.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,9 @@ def test_build_error_response_with_request_id_none(self):
9393
self.assertIsInstance(response_wrapper.root, JSONRPCErrorResponse)
9494
self.assertIsNone(response_wrapper.root.id)
9595

96-
def _create_sample_task(self, task_id='task123', context_id='ctx456'):
96+
def _create_sample_task(
97+
self, task_id: str = 'task123', context_id: str = 'ctx456'
98+
) -> Task:
9799
return Task(
98100
id=task_id,
99101
context_id=context_id,

tests/server/tasks/test_inmemory_push_notifications.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
def create_sample_task(
2121
task_id: str = 'task123', status_state: TaskState = TaskState.completed
22-
):
22+
) -> Task:
2323
return Task(
2424
id=task_id,
2525
context_id='ctx456',
@@ -31,7 +31,7 @@ def create_sample_push_config(
3131
url: str = 'http://example.com/callback',
3232
config_id: str = 'cfg1',
3333
token: str | None = None,
34-
):
34+
) -> PushNotificationConfig:
3535
return PushNotificationConfig(id=config_id, url=url, token=token)
3636

3737

tests/server/tasks/test_push_notification_sender.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
def create_sample_task(
1919
task_id: str = 'task123', status_state: TaskState = TaskState.completed
20-
):
20+
) -> Task:
2121
return Task(
2222
id=task_id,
2323
context_id='ctx456',
@@ -29,7 +29,7 @@ def create_sample_push_config(
2929
url: str = 'http://example.com/callback',
3030
config_id: str = 'cfg1',
3131
token: str | None = None,
32-
):
32+
) -> PushNotificationConfig:
3333
return PushNotificationConfig(id=config_id, url=url, token=token)
3434

3535

tests/server/tasks/test_result_aggregator.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import asyncio
2+
from typing_extensions import override
23
import unittest
34

45
from collections.abc import AsyncIterator
@@ -22,7 +23,7 @@
2223
# Helper to create a simple message
2324
def create_sample_message(
2425
content: str = 'test message', msg_id: str = 'msg1', role: Role = Role.user
25-
):
26+
) -> Message:
2627
return Message(
2728
message_id=msg_id,
2829
role=role,
@@ -35,7 +36,7 @@ def create_sample_task(
3536
task_id: str = 'task1',
3637
status_state: TaskState = TaskState.submitted,
3738
context_id: str = 'ctx1',
38-
):
39+
) -> Task:
3940
return Task(
4041
id=task_id,
4142
context_id=context_id,
@@ -45,8 +46,10 @@ def create_sample_task(
4546

4647
# Helper to create a TaskStatusUpdateEvent
4748
def create_sample_status_update(
48-
task_id='task1', status_state=TaskState.working, context_id='ctx1'
49-
):
49+
task_id: str = 'task1',
50+
status_state: TaskState = TaskState.working,
51+
context_id: str = 'ctx1',
52+
) -> TaskStatusUpdateEvent:
5053
return TaskStatusUpdateEvent(
5154
task_id=task_id,
5255
context_id=context_id,
@@ -56,6 +59,7 @@ def create_sample_status_update(
5659

5760

5861
class TestResultAggregator(unittest.IsolatedAsyncioTestCase):
62+
@override
5963
def setUp(self):
6064
self.mock_task_manager = AsyncMock(spec=TaskManager)
6165
self.mock_event_consumer = AsyncMock(spec=EventConsumer)

0 commit comments

Comments
 (0)