Skip to content

Commit 50d3604

Browse files
author
aacgn
committed
Atomic
- Fix small issue related with no declaration of transition page
1 parent 8079e26 commit 50d3604

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@aacgn/atomic",
3-
"version": "2.0.4-alpha",
3+
"version": "2.0.5-alpha",
44
"description": "A JavaScript library for building horizontal micro frontends interfaces",
55
"main": "./src/index.js",
66
"bin": "./src/index.js",

src/lib/@core/classes/atomic-router.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,16 @@ export class AtomicRouter {
5252
}
5353

5454
enableTransitionPage() {
55-
if (!this._isTransitionPageEnable)
55+
if (this._transitionPage && !this._isTransitionPageEnable) {
5656
mountTransitionPage(this._previousPageRendered, this._transitionPage);
57-
this._isTransitionPageEnable = true;
57+
this._isTransitionPageEnable = true;
58+
}
5859
}
5960

6061
disableTransitionPage() {
61-
unmountTransitionPage(this._previousPageRendered, this._transitionPage);
62-
this._isTransitionPageEnable = false;
62+
if (this._transitionPage)
63+
unmountTransitionPage(this._previousPageRendered, this._transitionPage);
64+
this._isTransitionPageEnable = false;
6365
}
6466

6567
_useWindowHistoryChangeInterceptor() {

0 commit comments

Comments
 (0)