Refactor: move shared StateTree helpers into StateTreeHelpers namespace (#3)

Fixes C2084 duplicate-definition errors that surface under unity builds by consolidating ResolveSchemaClass and the four enum parsers into the existing StateTreeHelpers namespace. Also adds the TryFollowTransitions case to ParseSelectionBehavior.

Author: aniunio

Source/UnrealMCPBridge/Private/Commands/StateTree/StateTreeCreateOps.cpp

@@ -186,185 +186,6 @@ static TSharedPtr<FJsonObject> NodeToJsonResult(const FStateTreeEditorNode& Node
 	return Obj;
 }
 
-/**
- * Resolve a UStateTreeSchema subclass by short name or full path.
- */
-static UClass* ResolveSchemaClass(const FString& SchemaName, FString& OutError)
-{
-	if (SchemaName.IsEmpty())
-	{
-		OutError = TEXT("Empty schema_class");
-		return nullptr;
-	}
-
-	// Try full path
-	UClass* Found = FindObject<UClass>(nullptr, *SchemaName);
-	if (Found && Found->IsChildOf(UStateTreeSchema::StaticClass()))
-	{
-		return Found;
-	}
-
-	// Search by short name
-	TArray<UClass*> Derived;
-	GetDerivedClasses(UStateTreeSchema::StaticClass(), Derived, true);
-	for (UClass* C : Derived)
-	{
-		if (!C || C->HasAnyClassFlags(CLASS_Abstract))
-		{
-			continue;
-		}
-
-		const FString Name = C->GetName();
-		if (Name == SchemaName ||
-			Name == (TEXT("U") + SchemaName) ||
-			(SchemaName.StartsWith(TEXT("U")) && Name == SchemaName.RightChop(1)))
-		{
-			return C;
-		}
-	}
-
-	OutError = FString::Printf(TEXT("Schema class not found: '%s'"), *SchemaName);
-	return nullptr;
-}
-
-/**
- * Parse an EStateTreeStateType from a string.
- */
-static bool ParseStateType(const FString& Str, EStateTreeStateType& OutType)
-{
-	if (Str.IsEmpty() || Str.Equals(TEXT("State"), ESearchCase::IgnoreCase))
-	{
-		OutType = EStateTreeStateType::State;
-		return true;
-	}
-	if (Str.Equals(TEXT("Group"), ESearchCase::IgnoreCase))
-	{
-		OutType = EStateTreeStateType::Group;
-		return true;
-	}
-	if (Str.Equals(TEXT("Linked"), ESearchCase::IgnoreCase))
-	{
-		OutType = EStateTreeStateType::Linked;
-		return true;
-	}
-	if (Str.Equals(TEXT("LinkedAsset"), ESearchCase::IgnoreCase))
-	{
-		OutType = EStateTreeStateType::LinkedAsset;
-		return true;
-	}
-	if (Str.Equals(TEXT("Subtree"), ESearchCase::IgnoreCase))
-	{
-		OutType = EStateTreeStateType::Subtree;
-		return true;
-	}
-	return false;
-}
-
-/**
- * Parse an EStateTreeStateSelectionBehavior from a string.
- */
-static bool ParseSelectionBehavior(const FString& Str, EStateTreeStateSelectionBehavior& OutBehavior)
-{
-	if (Str.Equals(TEXT("None"), ESearchCase::IgnoreCase))
-	{
-		OutBehavior = EStateTreeStateSelectionBehavior::None;
-		return true;
-	}
-	if (Str.Equals(TEXT("TryEnterState"), ESearchCase::IgnoreCase) ||
-		Str.Equals(TEXT("TryEnter"), ESearchCase::IgnoreCase))
-	{
-		OutBehavior = EStateTreeStateSelectionBehavior::TryEnterState;
-		return true;
-	}
-	if (Str.Equals(TEXT("TrySelectChildrenInOrder"), ESearchCase::IgnoreCase))
-	{
-		OutBehavior = EStateTreeStateSelectionBehavior::TrySelectChildrenInOrder;
-		return true;
-	}
-	if (Str.Equals(TEXT("TrySelectChildrenAtRandom"), ESearchCase::IgnoreCase))
-	{
-		OutBehavior = EStateTreeStateSelectionBehavior::TrySelectChildrenAtRandom;
-		return true;
-	}
-	if (Str.Equals(TEXT("TrySelectChildrenWithHighestUtility"), ESearchCase::IgnoreCase))
-	{
-		OutBehavior = EStateTreeStateSelectionBehavior::TrySelectChildrenWithHighestUtility;
-		return true;
-	}
-	if (Str.Equals(TEXT("TrySelectChildrenAtRandomWeightedByUtility"), ESearchCase::IgnoreCase))
-	{
-		OutBehavior = EStateTreeStateSelectionBehavior::TrySelectChildrenAtRandomWeightedByUtility;
-		return true;
-	}
-	return false;
-}
-
-/**
- * Parse an EStateTreeTransitionTrigger from a string.
- */
-static bool ParseTransitionTrigger(const FString& Str, EStateTreeTransitionTrigger& OutTrigger)
-{
-	if (Str.Equals(TEXT("OnStateCompleted"), ESearchCase::IgnoreCase))
-	{
-		OutTrigger = EStateTreeTransitionTrigger::OnStateCompleted;
-		return true;
-	}
-	if (Str.Equals(TEXT("OnStateSucceeded"), ESearchCase::IgnoreCase))
-	{
-		OutTrigger = EStateTreeTransitionTrigger::OnStateSucceeded;
-		return true;
-	}
-	if (Str.Equals(TEXT("OnStateFailed"), ESearchCase::IgnoreCase))
-	{
-		OutTrigger = EStateTreeTransitionTrigger::OnStateFailed;
-		return true;
-	}
-	if (Str.Equals(TEXT("OnTick"), ESearchCase::IgnoreCase))
-	{
-		OutTrigger = EStateTreeTransitionTrigger::OnTick;
-		return true;
-	}
-	if (Str.Equals(TEXT("OnEvent"), ESearchCase::IgnoreCase))
-	{
-		OutTrigger = EStateTreeTransitionTrigger::OnEvent;
-		return true;
-	}
-	return false;
-}
-
-/**
- * Parse an EStateTreeTransitionPriority from a string.
- */
-static bool ParseTransitionPriority(const FString& Str, EStateTreeTransitionPriority& OutPriority)
-{
-	if (Str.IsEmpty() || Str.Equals(TEXT("Normal"), ESearchCase::IgnoreCase))
-	{
-		OutPriority = EStateTreeTransitionPriority::Normal;
-		return true;
-	}
-	if (Str.Equals(TEXT("Low"), ESearchCase::IgnoreCase))
-	{
-		OutPriority = EStateTreeTransitionPriority::Low;
-		return true;
-	}
-	if (Str.Equals(TEXT("Medium"), ESearchCase::IgnoreCase))
-	{
-		OutPriority = EStateTreeTransitionPriority::Medium;
-		return true;
-	}
-	if (Str.Equals(TEXT("High"), ESearchCase::IgnoreCase))
-	{
-		OutPriority = EStateTreeTransitionPriority::High;
-		return true;
-	}
-	if (Str.Equals(TEXT("Critical"), ESearchCase::IgnoreCase))
-	{
-		OutPriority = EStateTreeTransitionPriority::Critical;
-		return true;
-	}
-	return false;
-}
-
 /**
  * Parse an EPropertyBagPropertyType from a user-facing type string.
  * Returns None on unknown types. Also outputs a UScriptStruct* for struct types.
@@ -491,7 +312,7 @@ TSharedPtr<FJsonObject> FEpicUnrealMCPStateTreeCommands::HandleCreateStateTree(
 
 	// Resolve schema class
 	FString SchemaError;
-	UClass* SchemaClass = ResolveSchemaClass(SchemaClassName, SchemaError);
+	UClass* SchemaClass = StateTreeHelpers::ResolveSchemaClass(SchemaClassName, SchemaError);
 	if (!SchemaClass)
 	{
 		return FEpicUnrealMCPCommonUtils::CreateErrorResponse(SchemaError);
@@ -571,7 +392,7 @@ TSharedPtr<FJsonObject> FEpicUnrealMCPStateTreeCommands::HandleAddStateTreeState
 	FString StateTypeStr;
 	Params->TryGetStringField(TEXT("state_type"), StateTypeStr);
 	EStateTreeStateType StateType = EStateTreeStateType::State;
-	if (!StateTypeStr.IsEmpty() && !ParseStateType(StateTypeStr, StateType))
+	if (!StateTypeStr.IsEmpty() && !StateTreeHelpers::ParseStateType(StateTypeStr, StateType))
 	{
 		return FEpicUnrealMCPCommonUtils::CreateErrorResponse(
 			FString::Printf(TEXT("Invalid state_type: '%s'"), *StateTypeStr));
@@ -643,7 +464,7 @@ TSharedPtr<FJsonObject> FEpicUnrealMCPStateTreeCommands::HandleAddStateTreeState
 	if (Params->TryGetStringField(TEXT("selection_behavior"), SelectionStr))
 	{
 		EStateTreeStateSelectionBehavior Behavior;
-		if (ParseSelectionBehavior(SelectionStr, Behavior))
+		if (StateTreeHelpers::ParseSelectionBehavior(SelectionStr, Behavior))
 		{
 			NewState->SelectionBehavior = Behavior;
 		}
@@ -1058,7 +879,7 @@ TSharedPtr<FJsonObject> FEpicUnrealMCPStateTreeCommands::HandleAddStateTreeTrans
 
 	// Parse trigger
 	EStateTreeTransitionTrigger Trigger;
-	if (!ParseTransitionTrigger(TriggerStr, Trigger))
+	if (!StateTreeHelpers::ParseTransitionTrigger(TriggerStr, Trigger))
 	{
 		return FEpicUnrealMCPCommonUtils::CreateErrorResponse(
 			FString::Printf(TEXT("Invalid trigger: '%s'"), *TriggerStr));
@@ -1068,7 +889,7 @@ TSharedPtr<FJsonObject> FEpicUnrealMCPStateTreeCommands::HandleAddStateTreeTrans
 	FString PriorityStr;
 	Params->TryGetStringField(TEXT("priority"), PriorityStr);
 	EStateTreeTransitionPriority Priority = EStateTreeTransitionPriority::Normal;
-	if (!PriorityStr.IsEmpty() && !ParseTransitionPriority(PriorityStr, Priority))
+	if (!PriorityStr.IsEmpty() && !StateTreeHelpers::ParseTransitionPriority(PriorityStr, Priority))
 	{
 		return FEpicUnrealMCPCommonUtils::CreateErrorResponse(
 			FString::Printf(TEXT("Invalid priority: '%s'"), *PriorityStr));