Skip to content

Commit 04e8932

Browse files
committed
chore: address ui refactor review feedback
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
1 parent fe4c847 commit 04e8932

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

  • .agents/skills/ui-refactor-review

.agents/skills/ui-refactor-review/SKILL.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ existing architecture and patterns over generic frontend advice.
2222
- Review the final shape of the changed code, not whether it is better than what came before.
2323
- Judge changes by whether they leave the code easier to maintain and extend in future work, not just whether they are correct today.
2424
- Produce an actionable checklist instead of vague feedback.
25-
- Fix issues in a safe order by default.
25+
- Ask for approval before making code changes unless the user explicitly asks for fixes.
2626
- Preserve `ui/goose2` boundaries: `ui/`, `hooks/`, `api/`, `lib/`, `stores/`, and `shared/`.
2727

2828
## Workflow
@@ -66,11 +66,12 @@ existing architecture and patterns over generic frontend advice.
6666
- `Issues`
6767
- one ordered `Checklist` for the whole reviewed scope
6868
- Do not stop after the findings until the ordered checklist is complete.
69-
9. Fix checklist items in order, using the `Rules` below as the quality bar for the implementation.
69+
9. Stop after the checklist and ask for approval before making code changes, unless the user explicitly asked to implement fixes.
70+
10. Fix approved checklist items in order, using the `Rules` below as the quality bar for the implementation.
7071
- State the main maintainability problem in one sentence.
7172
- Fix the highest-value items first.
7273
- Make the smallest behavior-preserving change that clearly improves the code.
73-
10. Summarize what changed, what remains, and what verification ran.
74+
11. Summarize what changed, what remains, and what verification ran.
7475

7576
## Strict Mode
7677

@@ -169,7 +170,9 @@ Before finalizing the review, explicitly ask:
169170
- Prefer straight-line render logic, guard clauses, and early returns over deep nesting.
170171
- Prefer controlled components where practical.
171172
- Use semantic HTML like `<main>`, `<nav>`, `<header>`, and `<aside>`.
172-
- Every plain `<button>` must include an explicit `type` attribute. Use `type="button"` unless the control is intentionally submitting or resetting a form.
173+
- Prefer existing shared UI button primitives over plain `<button>` elements.
174+
- Treat new plain `<button>` usage as a refactor smell unless there is a specific semantic or integration reason.
175+
- If a plain `<button>` is genuinely necessary, it must use `type="button"` in goose2.
173176
- Use `cn()` from `@/shared/lib/cn` for Tailwind class merging.
174177
- Prefer existing shared UI primitives before creating new one-off markup patterns.
175178
- Avoid inline styles except for truly dynamic values.

0 commit comments

Comments
 (0)