Update rmcp to 1.5.0 (fixes #8453) (#8618)

Author: jh-block

Cargo.lock

@@ -20,7 +20,7 @@ uninlined_format_args = "allow"
 string_slice = "warn"
 
 [workspace.dependencies]
-rmcp = { version = "1.2.0", features = ["schemars", "auth"] }
+rmcp = { version = "1.5.0", features = ["schemars", "auth"] }
 agent-client-protocol-schema = { version = "0.11", features = ["unstable"] }
 sacp = "11.0.0"
 arboard = "3"

Cargo.toml

@@ -121,7 +121,7 @@ impl McpFixtureServer {
     }
 }
 
-#[tool_handler]
+#[tool_handler(router = self.tool_router)]
 impl ServerHandler for McpFixtureServer {
     fn get_info(&self) -> ServerInfo {
         InitializeResult::new(ServerCapabilities::builder().enable_tools().build())

crates/goose-test-support/src/mcp.rs

@@ -443,10 +443,7 @@ async fn create_streamable_http_client(
 
     let transport = StreamableHttpClientTransport::with_client(
         http_client,
-        StreamableHttpClientTransportConfig {
-            uri: uri.into(),
-            ..Default::default()
-        },
+        StreamableHttpClientTransportConfig::with_uri(uri),
     );
 
     let timeout_duration = Duration::from_secs(resolve_timeout(timeout));
@@ -475,10 +472,7 @@ async fn create_streamable_http_client(
                 let auth_client = AuthClient::new(auth_http_client, auth_manager);
                 let transport = StreamableHttpClientTransport::with_client(
                     auth_client,
-                    StreamableHttpClientTransportConfig {
-                        uri: uri.into(),
-                        ..Default::default()
-                    },
+                    StreamableHttpClientTransportConfig::with_uri(uri),
                 );
                 Ok(Box::new(
                     McpClient::connect(
@@ -2318,11 +2312,11 @@ mod tests {
 
     fn transport_err(error: Box<dyn std::error::Error + Send + Sync>) -> ClientInitializeError {
         ClientInitializeError::TransportError {
-            error: rmcp::transport::DynamicTransportError {
-                transport_name: "test".into(),
-                transport_type_id: std::any::TypeId::of::<()>(),
+            error: rmcp::transport::DynamicTransportError::from_parts(
+                "test",
+                std::any::TypeId::of::<()>(),
                 error,
-            },
+            ),
             context: "test context".into(),
         }
     }
@@ -2337,9 +2331,9 @@ mod tests {
     fn test_oauth_fallback_on_typed_auth_required() {
         let err = streamable_err(
             rmcp::transport::streamable_http_client::StreamableHttpError::AuthRequired(
-                rmcp::transport::streamable_http_client::AuthRequiredError {
-                    www_authenticate_header: "Bearer realm=\"test\"".to_string(),
-                },
+                rmcp::transport::streamable_http_client::AuthRequiredError::new(
+                    "Bearer realm=\"test\"".to_string(),
+                ),
             ),
         );
         assert!(should_attempt_oauth_fallback(&Err(err)));

crates/goose/src/agents/extension_manager.rs

@@ -330,6 +330,7 @@ impl ClientHandler for GooseClient {
             .map(|user_data| CreateElicitationResult {
                 action: ElicitationAction::Accept,
                 content: Some(user_data),
+                meta: None,
             })
             .map_err(|e| {
                 ErrorData::new(

crates/goose/src/agents/mcp_client.rs

@@ -115,17 +115,17 @@ pub async fn oauth_flow(
         .unwrap_or_default();
 
     credential_store
-        .save(StoredCredentials {
+        .save(StoredCredentials::new(
             client_id,
             token_response,
             granted_scopes,
-            token_received_at: Some(
+            Some(
                 std::time::SystemTime::now()
                     .duration_since(std::time::UNIX_EPOCH)
                     .map(|duration| duration.as_secs())
                     .unwrap_or(0),
             ),
-        })
+        ))
         .await?;
 
     auth_manager.set_credential_store(credential_store);