refactor: address remaining code review items for link handling

- Update test description from 'Streamdown linkSafety modal' to
  'MarkdownLink'\''s LinkSafetyModal' to match actual implementation
- Clean up isExternalHref import/re-export in artifactPathPolicyCore:
  import once at top for local use, re-export the local binding instead
  of a separate re-export-from-source statement
- Move hardcoded English strings in LinkSafetyModal to react-i18next
  under components.linkSafety namespace for i18n consistency
- Add comment on MessageResponse memo comparator explaining that
  internal state (modalUrl) is intentionally outside the comparator

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>

Author: matt2e

ui/goose2/src/features/chat/hooks/__tests__/useArtifactLinkHandler.test.tsx

@@ -110,7 +110,7 @@ describe("useArtifactLinkHandler", () => {
     );
   });
 
-  it("does not intercept external URLs (defers to Streamdown linkSafety modal)", async () => {
+  it("does not intercept external URLs (defers to MarkdownLink's LinkSafetyModal)", async () => {
     const user = userEvent.setup();
 
     render(<Harness href="https://example.com" label="External" />);

ui/goose2/src/features/chat/lib/artifactPathPolicyCore.ts

@@ -146,7 +146,7 @@ function hasKnownScheme(value: string): boolean {
   return /^[a-zA-Z][a-zA-Z\d+.-]*:/.test(value);
 }
 
-export { isExternalHref } from "@/shared/lib/isExternalHref";
+export { isExternalHref };
 
 function isLikelyAbsoluteFilesystemPath(candidate: string): boolean {
   if (/^[a-zA-Z]:[\\/]/.test(candidate)) return true;

ui/goose2/src/shared/i18n/locales/en/common.json

@@ -45,6 +45,13 @@
       "title": "Environment Variables",
       "toggleVisibility": "Toggle value visibility"
     },
+    "linkSafety": {
+      "copied": "Copied!",
+      "copyLink": "Copy link",
+      "description": "You're about to visit an external website.",
+      "openLink": "Open link",
+      "title": "Open external link?"
+    },
     "messageBranch": {
       "next": "Next branch",
       "page": "{{current}} of {{total}}",

ui/goose2/src/shared/ui/ai-elements/link-safety-modal.tsx

@@ -1,4 +1,5 @@
 import { useCallback, useEffect, useRef, useState } from "react";
+import { useTranslation } from "react-i18next";
 import { openUrl } from "@tauri-apps/plugin-opener";
 import { Button } from "@/shared/ui/button";
 import {
@@ -21,6 +22,7 @@ export function LinkSafetyModal({
   onClose,
   url,
 }: LinkSafetyModalProps) {
+  const { t } = useTranslation("common");
   const [isCopied, setIsCopied] = useState(false);
   const timeoutRef = useRef<number>(0);
 
@@ -68,9 +70,9 @@ export function LinkSafetyModal({
     <Dialog open={isOpen} onOpenChange={handleOpenChange}>
       <DialogContent>
         <DialogHeader>
-          <DialogTitle>Open external link?</DialogTitle>
+          <DialogTitle>{t("components.linkSafety.title")}</DialogTitle>
           <DialogDescription>
-            You&apos;re about to visit an external website.
+            {t("components.linkSafety.description")}
           </DialogDescription>
         </DialogHeader>
         <div className="break-all rounded-md bg-muted p-3 font-mono text-sm">
@@ -83,10 +85,12 @@ export function LinkSafetyModal({
             type="button"
             variant="outline"
           >
-            {isCopied ? "Copied!" : "Copy link"}
+            {isCopied
+              ? t("components.linkSafety.copied")
+              : t("components.linkSafety.copyLink")}
           </Button>
           <Button className="flex-1" onClick={handleOpen} type="button">
-            Open link
+            {t("components.linkSafety.openLink")}
           </Button>
         </DialogFooter>
       </DialogContent>

ui/goose2/src/shared/ui/ai-elements/message.tsx

@@ -414,6 +414,9 @@ export const MessageResponse = memo(
       </LinkSafetyContext.Provider>
     );
   },
+  // Internal state (modalUrl) is intentionally outside this comparator —
+  // React always re-renders when local state changes regardless of memo.
+  // If modalUrl is ever lifted to a prop, this comparator must be updated.
   (prevProps, nextProps) =>
     prevProps.children === nextProps.children &&
     nextProps.isAnimating === prevProps.isAnimating,