Skip to content

Commit c6755d3

Browse files
jamadeoDouwe Osinga
andauthored
Port provider tests to typescript (#8237)
Signed-off-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Douwe Osinga <douwe@squareup.com>
1 parent eb60770 commit c6755d3

10 files changed

Lines changed: 549 additions & 369 deletions

.github/workflows/pr-smoke-test.yml

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,11 @@ jobs:
110110
- name: Install agentic providers
111111
run: npm install -g @anthropic-ai/claude-code @zed-industries/claude-agent-acp @zed-industries/codex-acp
112112

113-
- name: Run Smoke Tests with Provider Script
113+
- name: Install Node.js Dependencies
114+
run: source ../../bin/activate-hermit && pnpm install --frozen-lockfile
115+
working-directory: ui/desktop
116+
117+
- name: Run Smoke Tests (Normal Mode)
114118
env:
115119
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
116120
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
@@ -127,12 +131,10 @@ jobs:
127131
SKIP_BUILD: 1
128132
SKIP_PROVIDERS: ${{ vars.SKIP_PROVIDERS || '' }}
129133
run: |
130-
# Ensure the HOME directory structure exists
131134
mkdir -p $HOME/.local/share/goose/sessions
132135
mkdir -p $HOME/.config/goose
133-
134-
# Run the provider test script (binary already built and downloaded)
135-
bash scripts/test_providers.sh
136+
source ../../bin/activate-hermit && pnpm run test:integration:providers
137+
working-directory: ui/desktop
136138

137139
- name: Set up Python
138140
uses: actions/setup-python@v5
@@ -188,6 +190,10 @@ jobs:
188190
- name: Make Binary Executable
189191
run: chmod +x target/debug/goose
190192

193+
- name: Install Node.js Dependencies
194+
run: source ../../bin/activate-hermit && pnpm install --frozen-lockfile
195+
working-directory: ui/desktop
196+
191197
- name: Run Provider Tests (Code Execution Mode)
192198
env:
193199
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
@@ -205,7 +211,8 @@ jobs:
205211
run: |
206212
mkdir -p $HOME/.local/share/goose/sessions
207213
mkdir -p $HOME/.config/goose
208-
bash scripts/test_providers_code_exec.sh
214+
source ../../bin/activate-hermit && pnpm run test:integration:providers-code-exec
215+
working-directory: ui/desktop
209216

210217
compaction-tests:
211218
name: Compaction Tests
@@ -277,7 +284,8 @@ jobs:
277284
GOOSE_PROVIDER: anthropic
278285
GOOSE_MODEL: claude-sonnet-4-5-20250929
279286
SHELL: /bin/bash
287+
SKIP_BUILD: 1
280288
run: |
281289
echo 'export PATH=/some/fake/path:$PATH' >> $HOME/.bash_profile
282-
source ../../bin/activate-hermit && pnpm run test:integration:debug
290+
source ../../bin/activate-hermit && pnpm run test:integration:goosed
283291
working-directory: ui/desktop

RELEASE_CHECKLIST.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Make a copy of this document for each version and check off as steps are verifie
1717

1818
### Provider Testing
1919

20-
- [ ] Run `./scripts/test_providers.sh` locally from the release branch and verify all providers/models work
20+
- [ ] Run `cd ui/desktop && pnpm run test:integration:providers` locally from the release branch and verify all providers/models work
2121
- [ ] Launch goose, click reset providers, choose databricks and a model
2222

2323
### Starting Conversations

scripts/test_providers.sh

Lines changed: 0 additions & 71 deletions
This file was deleted.

scripts/test_providers_code_exec.sh

Lines changed: 0 additions & 45 deletions
This file was deleted.

0 commit comments

Comments
 (0)