Merge remote-tracking branch 'origin/main' into wpfleger/tool-response-issue

* origin/main:
  Fix max turns configuration (#7612)
  feat: add base path field to custom provider configuration (#7614)
  fix: compare extension configs before skipping add_extension (#7650)
  chore(release): release version 1.27.0 (minor) (#7611)
  feat: better private channel detection, bot version debugging (#7680)
  chore(deps): bump svgo from 3.3.2 to 3.3.3 in /documentation (#7667)
  fix: only add viewable channels to bot context (#7678)
  chore: added a recipe to help identify high risk change prs for testing (#7651)
  fix: make sure platform binary exists (#7676)

Author: wpfleger96

.github/workflows/bundle-desktop-linux.yml

@@ -134,7 +134,7 @@ jobs:
         run: |
           source ./bin/activate-hermit
           cd ui/desktop
-          npm install
+          npm ci
           # Verify installation
           ls -la node_modules/.bin/ | head -5
 

.github/workflows/bundle-desktop-windows.yml

@@ -137,7 +137,7 @@ jobs:
         run: |
           cd ui/desktop
 
-          npm install
+          npm ci
           node scripts/build-main.js
           node scripts/prepare-platform-binaries.js
           npm run make -- --platform=win32 --arch=x64

.github/workflows/ci.yml

@@ -151,6 +151,10 @@ jobs:
       #     restore-keys: |
       #       ci-npm-cache-v1-${{ runner.os }}-
 
+      - name: Check lockfile has cross-platform entries
+        run: ./scripts/check-lockfile-platforms.sh
+        working-directory: ui/desktop
+
       - name: Install Dependencies
         run: source ../../bin/activate-hermit && npm ci
         working-directory: ui/desktop

Cargo.lock

@@ -4,7 +4,7 @@ resolver = "2"
 
 [workspace.package]
 edition = "2021"
-version = "1.26.0"
+version = "1.27.0"
 authors = ["Block <ai-oss-tools@block.xyz>"]
 license = "Apache-2.0"
 repository = "https://github.com/block/goose"

Cargo.toml

@@ -125,7 +125,7 @@ copy-binary-windows:
 run-ui:
     @just release-binary
     @echo "Running UI..."
-    cd ui/desktop && npm install && npm run start-gui
+    cd ui/desktop && npm ci && npm run start-gui
 
 run-ui-playwright:
     #!/usr/bin/env sh
@@ -138,14 +138,14 @@ run-ui-playwright:
 
 run-ui-only:
     @echo "Running UI..."
-    cd ui/desktop && npm install && npm run start-gui
+    cd ui/desktop && npm ci && npm run start-gui
 
 debug-ui *alpha:
     @echo "🚀 Starting goose frontend in external backend mode{{ if alpha == "alpha" { " with alpha features enabled" } else { "" } }}"
     cd ui/desktop && \
     export GOOSE_EXTERNAL_BACKEND=true && \
     {{ if alpha == "alpha" { "export ALPHA=true &&" } else { "" } }} \
-    npm install && \
+    npm ci && \
     npm run {{ if alpha == "alpha" { "start-alpha-gui" } else { "start-gui" } }}
 
 # Run UI with main process debugging enabled
@@ -159,15 +159,15 @@ debug-ui-main-process:
 	@echo "🔍 Starting goose UI with main process debugging enabled"
 	@just release-binary
 	cd ui/desktop && \
-	npm install && \
+	npm ci && \
 	npm run start-gui-debug
 
 # Package the desktop app locally for testing (macOS)
 # Applies ad-hoc code signing with entitlements (needed for mic access, etc.)
 package-ui:
     @just release-binary
     @echo "Packaging desktop app..."
-    cd ui/desktop && npm install && npm run package
+    cd ui/desktop && npm ci && npm run package
     @echo "Signing with entitlements..."
     codesign --force --deep --sign - --entitlements ui/desktop/entitlements.plist ui/desktop/out/Goose-darwin-arm64/Goose.app
     @echo "Done! Launch with: open ui/desktop/out/Goose-darwin-arm64/Goose.app"
@@ -176,14 +176,14 @@ package-ui:
 run-ui-alpha:
     @just release-binary
     @echo "Running UI with alpha features..."
-    cd ui/desktop && npm install && ALPHA=true npm run start-alpha-gui
+    cd ui/desktop && npm ci && ALPHA=true npm run start-alpha-gui
 
 # Run UI with latest (Windows version)
 run-ui-windows:
     @just release-windows
     @powershell.exe -Command "Write-Host 'Copying Windows binary...'"
     @just copy-binary-windows
-    @powershell.exe -Command "Write-Host 'Running UI...'; Set-Location ui/desktop; npm install; npm run start-gui"
+    @powershell.exe -Command "Write-Host 'Running UI...'; Set-Location ui/desktop; npm ci; npm run start-gui"
 
 # Run Docusaurus server for documentation
 run-docs:
@@ -386,7 +386,7 @@ win-bld-rls-all:
 
 ### Install npm stuff
 win-app-deps:
-  cd ui{{s}}desktop ; npm install
+  cd ui{{s}}desktop ; npm ci
 
 ### Windows copy {release|debug} files to ui\desktop\src\bin
 ### s = os dependent file separator

Justfile

@@ -2,14 +2,25 @@
 
 ## Version: {{VERSION}}
 
+### Identify the high risk changes in this Release
+
+```
+./workflow_recipes/release_risk_check/run.sh {{VERSION}}
+```
+
+It will generate an analysis report in `/tmp/release_report_final.md` and perform testing is necessary for high risk pr changes. 
+
+
+## Regression Testing
+
 Make a copy of this document for each version and check off as steps are verified.
 
-## Provider Testing
+### Provider Testing
 
 - [ ] Run `./scripts/test_providers.sh` locally from the release branch and verify all providers/models work
 - [ ] Launch goose, click reset providers, choose databricks and a model
 
-## Starting Conversations
+### Starting Conversations
 
 Test various ways to start a conversation:
 
@@ -26,9 +37,9 @@ Test various ways to start a conversation:
 - [ ] Open a new window, click chat in left side for new chat
 - [ ] Click "create a tamagotchi game" in popular chat topics to test developer extension
 
-## Recipes
+### Recipes
 
-### Create Recipe from Session
+#### Create Recipe from Session
 
 - [ ] Start a simple chat conversation like "hi"
 - [ ] Click "create a recipe from this session" in the bottom chat bar
@@ -37,7 +48,7 @@ Test various ways to start a conversation:
   - [ ] Can launch create and run recipe - launches in a new window showing as a recipe agent chat with parameters filled in and interact with it
   - [ ] Recipe should be saved in recipe library
 
-### Use Existing Recipe
+#### Use Existing Recipe
 
 - [ ] Pick trip planner from recipe hub (go/gooserecipes)
   - [ ] See the warning whether to trust this recipe (only on fresh install)
@@ -46,7 +57,7 @@ Test various ways to start a conversation:
   - [ ] Check results are reasonable
   - [ ] Ask how many days the trip is for - should say 14
 
-### Recipe Management
+#### Recipe Management
 
 - [ ] Go to recipe manager and enter a new recipe to generate a joke
   - [ ] See that it works if you run it
@@ -56,7 +67,7 @@ Test various ways to start a conversation:
   - [ ] Delete the recipe from the recipe manager
   - [ ] Verify recipe is actually deleted
 
-### Recipe from File
+#### Recipe from File
 
 - [ ] Create a file `~/.config/goose/recipes/test-recipe.yaml` with the following content:
 
@@ -79,40 +90,40 @@ recipe:
 - [ ] Go to hub and enter "what is the value of test_param"
 - [ ] See a new chat that says it has no idea (recipe is no longer active)
 
-## Extensions
+### Extensions
 
-### Manual Extension Addition
+#### Manual Extension Addition
 
 - [ ] Can manually add an extension using random quotes from project
   - [ ] Add new custom stdio extension with the following command and save:
     - [ ] `node /ABSOLUTE/PATH/TO/goose/ui/desktop/tests/e2e/basic-mcp.ts` (use your actual project path)
     - [ ] Should add and can chat to ask for a random quote
 
-### Playwright Extension
+#### Playwright Extension
 
 - [ ] Install the playwright extension from the extensions hub
   - [ ] Tell it to open a browser and search on Google for cats
   - [ ] Verify that the browser opens and navigates
 
-### Extension with Environment Variables
+#### Extension with Environment Variables
 
 - [ ] Install an extension from deeplink that needs env variables:
   - [ ] Use: `goose://extension?cmd=npx&arg=-y&arg=%40upstash%2Fcontext7-mcp&id=context7&name=Context7&description=Use%20up-to-date%20code%20and%20docs&env=TEST_ACCESS_TOKEN`
   - [ ] Extension page should load with env variables modal showing
   - [ ] Allow form input and saving extension
 
-## Speech-to-Text (Local Model)
+### Speech-to-Text (Local Model)
 
 - [ ] Go to Settings > Chat > Voice dictation provider and select the small model
 - [ ] Run a quick test that speech-to-text is working (click the mic button, speak, verify transcription)
 - [ ] Also try OpenAI using your OpenAI key
 
-## Settings
+### Settings
 
 - [ ] Settings page loads and all tabs load
 - [ ] Can change dark mode setting
 
-## Follow-up Issues
+### Follow-up Issues
 
 Link any GitHub issues filed during testing:
 

RELEASE_CHECKLIST.md

@@ -2015,6 +2015,17 @@ fn add_provider() -> anyhow::Result<()> {
         .initial_value(true)
         .interact()?;
 
+    let base_path_input: String = cliclack::input("API base path (optional, press Enter to skip):")
+        .placeholder("e.g., v1/chat/completions or project_id/v1")
+        .required(false)
+        .interact()?;
+
+    let base_path = if base_path_input.trim().is_empty() {
+        None
+    } else {
+        Some(base_path_input)
+    };
+
     let headers = collect_custom_headers()?;
 
     create_custom_provider(CreateCustomProviderParams {
@@ -2027,7 +2038,7 @@ fn add_provider() -> anyhow::Result<()> {
         headers,
         requires_auth,
         catalog_provider_id: None,
-        base_path: None,
+        base_path,
     })?;
 
     cliclack::outro(format!("Custom provider added: {}", display_name))?;

crates/goose-cli/src/commands/configure.rs

@@ -1118,7 +1118,11 @@ impl Agent {
             let reply_stream_span = tracing::info_span!(target: "goose::agents::agent", "reply_stream");
             let _stream_guard = reply_stream_span.enter();
             let mut turns_taken = 0u32;
-            let max_turns = session_config.max_turns.unwrap_or(DEFAULT_MAX_TURNS);
+            let max_turns = session_config.max_turns.unwrap_or_else(|| {
+                Config::global()
+                    .get_param::<u32>("GOOSE_MAX_TURNS")
+                    .unwrap_or(DEFAULT_MAX_TURNS)
+            });
             let mut compaction_attempts = 0;
             let mut last_assistant_text = String::new();