fix: unify model picker loading to reduce flicker and redundant fetches

- Remove the redundant getProviderInventory() call that fired every time
  the picker popover opened, duplicating work already done by
  useAppStartup's polling
- When models are loading but the current model name is already known,
  show it as a placeholder item with a spinner instead of a generic
  "Loading models" message, keeping the dropdown consistent with the
  button label

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: matt2e

ui/goose2/src/features/chat/ui/AgentModelPicker.tsx

@@ -7,8 +7,6 @@ import {
 } from "@tabler/icons-react";
 import { useTranslation } from "react-i18next";
 import type { AcpProvider } from "@/shared/api/acp";
-import { getProviderInventory } from "@/features/providers/api/inventory";
-import { useProviderInventoryStore } from "@/features/providers/stores/providerInventoryStore";
 import { cn } from "@/shared/lib/cn";
 import { Button } from "@/shared/ui/button";
 import { Popover, PopoverContent, PopoverTrigger } from "@/shared/ui/popover";
@@ -325,10 +323,6 @@ export function AgentModelPicker({
   const { t } = useTranslation("chat");
   const [open, setOpen] = useState(false);
   const [modelView, setModelView] = useState<ModelView>("recommended");
-  const mergeInventoryEntries = useProviderInventoryStore(
-    (s) => s.mergeEntries,
-  );
-
   const selectedAgentLabel =
     agents.find((agent) => agent.id === selectedAgentId)?.label ??
     formatProviderLabel(selectedAgentId);
@@ -358,32 +352,6 @@ export function AgentModelPicker({
     }
   }, [open]);
 
-  useEffect(() => {
-    if (!open) {
-      return;
-    }
-
-    let cancelled = false;
-
-    const syncInventory = async () => {
-      try {
-        const entries = await getProviderInventory();
-        if (cancelled) {
-          return;
-        }
-        mergeInventoryEntries(entries);
-      } catch (error) {
-        console.error("Failed to sync provider inventory from picker:", error);
-      }
-    };
-
-    void syncInventory();
-
-    return () => {
-      cancelled = true;
-    };
-  }, [open, mergeInventoryEntries]);
-
   // When in "all" view, expand the popover to full width for the search experience.
   const isAllView = modelView === "all";
 
@@ -512,9 +480,25 @@ export function AgentModelPicker({
             className="flex min-h-0 min-w-0 overflow-hidden p-1"
           >
             {modelsLoading ? (
-              <div className="flex min-h-0 flex-1 items-center gap-2 px-2 py-2 text-sm text-muted-foreground">
-                <Spinner className="size-4" />
-                <span>{t("toolbar.loadingModels")}</span>
+              <div className="flex min-h-0 min-w-0 flex-1 flex-col">
+                <div className="shrink-0 px-2 py-1.5 text-sm font-semibold">
+                  {t("toolbar.model")}
+                </div>
+                {currentModelName || currentModelId ? (
+                  <div className="space-y-0.5 p-1">
+                    <PickerItem selected disabled>
+                      <div className="min-w-0 flex-1 truncate">
+                        {currentModelName ?? currentModelId}
+                      </div>
+                      <Spinner className="size-3.5 shrink-0" />
+                    </PickerItem>
+                  </div>
+                ) : (
+                  <div className="flex min-h-0 flex-1 items-center gap-2 px-2 py-2 text-sm text-muted-foreground">
+                    <Spinner className="size-4" />
+                    <span>{t("toolbar.loadingModels")}</span>
+                  </div>
+                )}
               </div>
             ) : availableModels.length > 0 ? (
               modelView === "recommended" ? (