Skip to content

Commit 0d5cd88

Browse files
Revert "Commit 7c130ee"
This PR reverts commit 7c130ee, which was accidentally submitted. Original MR description: Only check for the presence of apiSubDomain, i.e. "model", as opposed to apiSubDomain+".", i.e. "model.", when determining whether the URL needs to be modified. This allows URLs such as `model-v1alpha.{domain}` to be unmodified by this logic, which is the desired behavior.
1 parent 7c130ee commit 0d5cd88

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/nbictl/connection.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func openAPIConnection(appCtx *cli.Context, apiSubDomain string) (*grpc.ClientCo
6464

6565
func adjustURLForAPISubDomain(url string, apiSubDomain string) string {
6666
// Unexpectedly empty arguments or already the subdomain sought.
67-
if url == "" || apiSubDomain == "" || strings.HasPrefix(url, apiSubDomain) {
67+
if url == "" || apiSubDomain == "" || strings.HasPrefix(url, apiSubDomain+".") {
6868
return url
6969
}
7070

0 commit comments

Comments
 (0)