fix: double-free when disposing CXPlatformAvailability

Author: aapoalas

deno.lock

@@ -2739,9 +2739,11 @@ export class CXCursor {
       }
       const platform = cxstringToString(
         availabilityBuffer.subarray(0, 16),
+        false,
       );
       const message = cxstringToString(
         availabilityBuffer.subarray(72 - 16),
+        false,
       );
       const view = new DataView(
         availabilityBuffer.buffer,

lib/mod.ts

@@ -58,22 +58,25 @@ export const cstrArray = (strings: string[]) => {
   }
 };
 
-export const cxstringToString = (cxstring: Uint8Array): string => {
+export const cxstringToString = (
+  cxstring: Uint8Array,
+  dispose = true,
+): string => {
   const cstring = libclang.symbols.clang_getCString(cxstring);
-  if (cstring === NULL) {
-    libclang.symbols.clang_disposeString(cxstring);
-    return "";
+  let string = "";
+  if (cstring !== NULL) {
+    try {
+      string = Deno.UnsafePointerView.getCString(cstring);
+    } catch {
+      const buf = new Uint8Array(
+        Deno.UnsafePointerView.getArrayBuffer(cstring, 1024),
+      );
+      string = cstrToString(buf.subarray(buf.indexOf(0)));
+    }
   }
-  let string: string;
-  try {
-    string = Deno.UnsafePointerView.getCString(cstring);
-  } catch {
-    const buf = new Uint8Array(
-      Deno.UnsafePointerView.getArrayBuffer(cstring, 1024),
-    );
-    string = cstrToString(buf.subarray(buf.indexOf(0)));
+  if (dispose) {
+    libclang.symbols.clang_disposeString(cxstring);
   }
-  libclang.symbols.clang_disposeString(cxstring);
   return string;
 };
 export const cstrToString = (cstr: Uint8Array): string =>

lib/utils.ts

@@ -3,7 +3,10 @@ import {
   assertNotEquals,
   assertThrows,
 } from "https://deno.land/[email protected]/testing/asserts.ts";
-import { CXChildVisitResult } from "../lib/include/typeDefinitions.ts";
+import {
+  CXChildVisitResult,
+  CXCursorKind,
+} from "../lib/include/typeDefinitions.ts";
 import { CXDiagnosticSet, CXIndex } from "../lib/mod.ts";
 
 Deno.test("class CXIndex", async (t) => {
@@ -118,29 +121,42 @@ Deno.test("class CXTranslationUnit", async (t) => {
     const index = new CXIndex();
     const tu = index.parseTranslationUnit("./test/assets/test.h");
     const tu2 = index.parseTranslationUnit("./test/assets/test.hpp");
-    console.log("Diag count:", tu2.getNumberOfDiagnostics());
+    //console.log("Diag count:", tu2.getNumberOfDiagnostics());
     const file = tu.getFile("./test/assets/test.h");
     assertNotEquals(file, null);
     const contents = file!.getContents();
     assertEquals(contents.startsWith("// my_class.h"), true);
     assertEquals(contents.length, 171);
     const cursor = tu.getCursor();
     assertEquals(cursor.getBriefCommentText(), "");
-    console.log(cursor.kind);
+    //console.log(cursor.kind);
 
     cursor.visitChildren((cursor) => {
-      console.log(cursor.kind);
+      //console.log(cursor.kind);
       return CXChildVisitResult.CXChildVisit_Recurse;
     });
 
+    tu2.getCursor().visitChildren((cursor) => {
+      switch (cursor.kind) {
+        case CXCursorKind.CXCursor_Namespace:
+        case CXCursorKind.CXCursor_ClassDecl:
+          return CXChildVisitResult.CXChildVisit_Recurse;
+        case CXCursorKind.CXCursor_CXXMethod:
+          console.log(cursor.getPlatformAvailability());
+          console.log(cursor.getCXXManglings());
+      }
+      console.log(cursor.getKindSpelling());
+      return CXChildVisitResult.CXChildVisit_Continue;
+    });
+
     assertThrows(() => CXDiagnosticSet.loadDiagnostics("test-diag.foo"));
 
-    console.log(tu.getAllSkippedRanges());
+    //console.log(tu.getAllSkippedRanges());
     const resourceUsage = tu.getResourceUsage();
     const length = resourceUsage.length;
-    console.log("ResourceUsage length:", length);
+    //console.log("ResourceUsage length:", length);
     for (let i = 0; i < length; i++) {
-      console.log(resourceUsage.at(i));
+      //console.log(resourceUsage.at(i));
     }
     resourceUsage.dispose();
     tu.dispose();

test/CXTranslationUnit.test.ts

@@ -5,6 +5,9 @@
 namespace N {
 class my_class {
 public:
+#ifdef __linux__
+  [[deprecated("Boost it")]]
+#endif
   void do_something();
 private:
   int foo;