fix: change major tag workflow trigger from release to tag push events #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GitHub Actions workflow failure in major version tag management
Summary
This PR fixes the GitHub Actions workflow failure that occurred when the major version tag management workflow was triggered by
release.published
events. The root cause was that thenowactions/update-majorver@v1
action expects the GitHub context from tag push events, not release publication events.Key Changes:
on.release.types: [published]
toon.push.tags: ['v*.*.*']
nowactions/update-majorver@v1
actionWorkflow Behavior Change:
This maintains the two-workflow approach but changes the timing of major tag updates.
Review & Testing Checklist for Human
v1.4.0
) and verify that the major tag (e.g.,v1
) is automatically updated to point to the new tag.v*.*.*
matches your repository's existing tag format (currently using tags likev1.3.1
).Recommended Test Plan:
git tag v1.4.0 && git push origin v1.4.0
v1
tag to point tov1.4.0
Diagram
Notes
nowactions/update-majorver@v1
action was designed to work with tag push events (github.ref
context) but was being triggered by release publication events (github.event.release
context), causing undefined property access errors.Risk Assessment: 🟡 Medium - The workflow behavior change (tag push vs release publication timing) needs verification to ensure it aligns with the intended release management strategy.