Skip to content

Commit dc996bf

Browse files
committed
no need to explicitly cleanup
1 parent cfe6dfe commit dc996bf

3 files changed

Lines changed: 5 additions & 9 deletions

File tree

indi_allsky/darks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -829,7 +829,7 @@ def _run(self, stacking_class):
829829
def _take_exposures(self, exposure, dark_filename_t, bpm_filename_t, ccd_bits, stacking_class):
830830
exposure_f = float(exposure)
831831

832-
tmp_fit_dir = tempfile.TemporaryDirectory()
832+
tmp_fit_dir = tempfile.TemporaryDirectory() # context manager automatically deletes files when finished
833833
tmp_fit_dir_p = Path(tmp_fit_dir.name)
834834

835835
logger.info('Temp folder: %s', tmp_fit_dir_p)

indi_allsky/starTrails.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,10 @@ def __init__(self, config, bin_v, mask=None):
7272
self.image_dir = Path(__file__).parent.parent.joinpath('html', 'images').absolute()
7373

7474

75-
self.timelapse_tmpdir = tempfile.TemporaryDirectory(dir=self.image_dir, suffix='_startrail_timelapse')
75+
self.timelapse_tmpdir = tempfile.TemporaryDirectory(dir=self.image_dir, suffix='_startrail_timelapse') # context manager automatically deletes files when finished
7676
self.timelapse_tmpdir_p = Path(self.timelapse_tmpdir.name)
7777

7878

79-
def __del__(self):
80-
self.cleanup()
81-
8279

8380
@property
8481
def max_brightness(self):

indi_allsky/timelapse.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,11 @@ class TimelapseGenerator(object):
1717
def __init__(self, config):
1818
self.config = config
1919

20-
self.seqfolder = tempfile.TemporaryDirectory(suffix='_timelapse')
20+
self.seqfolder = tempfile.TemporaryDirectory(suffix='_timelapse') # context manager automatically deletes files when finished
2121
self.seqfolder_p = Path(self.seqfolder.name)
2222

23-
24-
def __del__(self):
25-
self.cleanup()
23+
#seqfolder = tempfile.mkdtemp(suffix='_timelapse') # testing
24+
#self.seqfolder_p = Path(seqfolder)
2625

2726

2827
def generate(self, video_file, file_list):

0 commit comments

Comments
 (0)