Moon overlay - negative values?

[danteffm]

Hi, and first of all thank you again for your great work on indi-allsky — the Moon Overlay feature is a really nice addition.

I may have found something that behaves a bit differently than expected, and I wanted to share it in case it’s useful.

The Moon Overlay UI currently states:

“Negative is offset from the right side of image (Not validated with image size)”
“Negative is offset from the bottom of image”

Based on this, I assumed that negative X/Y values would behave the same way as they do for text labels — meaning that:

X < 0 would place the moon relative to the right edge,

Y < 0 would place it relative to the bottom edge.

However, when I set:

X = -30
Y = -30
Scale = 0.5

the overlay consistently fails with the following errors:

Moon overlay X offset places moon outside image boundary
Moon overlay Y offset places moon outside image boundary

Using positive absolute coordinates works perfectly (e.g. on a 3840×2160 image, placing the moon at X=3610, Y=1930 with scale 0.5 is fine).
This makes me think that negative offsets might not actually be supported by the current implementation, even though the UI text suggests that they are.

I might be misunderstanding how this feature is intended to work, but I thought I would mention it because the current UI wording could easily make users assume that negative offsets behave like label offsets.

Thanks again for all your work on indi-allsky — this is just a small detail I noticed while configuring the overlay.

[aaronwmorris]

Those errors are more like warnings. The X/Y coordinates are for the upper-left corner of the moon image. -30/-30 would place part of the moon outside the image. The code should automatically adjust the coordinates so the moon is fully within view.