feat: use shared workflow (#194)

Author: sakulstra

.github/workflows/comment.yml

@@ -2,6 +2,7 @@ name: PR Comment
 
 on:
   workflow_run:
+    # The workflow generating the artifacts
     workflows: [Test]
     types:
       - completed
@@ -12,10 +13,11 @@ permissions:
   checks: read
   statuses: read
   pull-requests: write
-  contents: write
 
 jobs:
   comment:
     uses: bgd-labs/github-workflows/.github/workflows/comment.yml@main
     secrets:
+      # the provided PAT needs write and write permissions on issues and pull requests
+      # the PAT is only really needed when commenting of prs from forks
       READ_ONLY_PAT: ${{ secrets.READ_ONLY_PAT }}

.github/workflows/test.yml

@@ -1,3 +1,6 @@
+# This action runs all common tooling for foundry repos
+# It does not comment any results though.
+# If you want to have comments on your repo, also install comment.yml
 name: Test
 
 concurrency:
@@ -7,78 +10,13 @@ concurrency:
 on:
   pull_request:
   push:
-    branches:
-      - main
+    branches: [main]
 
 jobs:
   lint:
-    name: lint
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6
-        with:
-          node-version-file: .nvmrc
-          cache: "npm"
-
-      - name: install
-        run: npm ci --prefer-offline --no-audit
-
-      - name: lint
-        run: npm run lint
-
+    uses: bgd-labs/github-workflows/.github/workflows/foundry-lint-prettier.yml@main
   test:
-    name: Foundry build n test
-    runs-on: ubuntu-latest
-    env:
-      FOUNDRY_PROFILE: ci
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          submodules: recursive
-
-      - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6
-        with:
-          node-version-file: .nvmrc
-          cache: "npm"
-
-      - name: Install node dependencies
-        run: npm ci --prefer-offline --no-audit
-
-      - name: Run Foundry setup
-        uses: bgd-labs/github-workflows/.github/actions/foundry-setup@9ab528d7b505e74caf4e485d175fc0cc9ac1e9fb
-
-      - name: Run Forge tests
-        uses: bgd-labs/github-workflows/.github/actions/foundry-test@9ab528d7b505e74caf4e485d175fc0cc9ac1e9fb
-
-      - name: Run Gas report
-        uses: bgd-labs/github-workflows/.github/actions/foundry-gas-report@9ab528d7b505e74caf4e485d175fc0cc9ac1e9fb
-
-      - name: Cleanup
-        # This test will currently fail on coverage due to the gas limit beaing breached with optimizer disabled
-        run: rm tests/deployments/DeploymentsGasLimits.t.sol
-
-      - name: Run Lcov report
-        uses: bgd-labs/github-workflows/.github/actions/foundry-lcov-report@9ab528d7b505e74caf4e485d175fc0cc9ac1e9fb
-
-      - name: Save PR number
-        if: always() && (github.event_name == 'pull_request' || github.event_name == 'pull_request_target')
-        env:
-          PR_NUMBER: ${{ github.event.number }}
-        run: |
-          mkdir -p ./pr
-          echo $PR_NUMBER > /tmp/content/pr_number.txt
-
-      - uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: content
-          path: /tmp/content
-
-      # we let failing tests pass so we can log them in the comment, still we want the ci to fail
-      - name: Post test
-        if: ${{ env.testStatus != 0 }}
-        run: |
-          echo "tests failed"
-          exit 1
+    uses: bgd-labs/github-workflows/.github/workflows/foundry-test.yml@main
+# only when the repo has zksync code
+#  test-zk:
+#    uses: bgd-labs/github-workflows/.github/workflows/foundry-test-zk.yml@main

tests/deployments/DeploymentsGasLimits.t.sol

@@ -198,80 +198,4 @@ contract DeploymentsGasLimits is BatchTestProcedures {
       address(aaveV3SetupOne)
     );
   }
-
-  function testCheckInitCodeSizeBatchs() public pure {
-    uint16 maxInitCodeSize = 49152;
-
-    console.log('AaveV3SetupBatch', type(AaveV3SetupBatch).creationCode.length);
-    console.log('AaveV3L2PoolBatch', type(AaveV3L2PoolBatch).creationCode.length);
-    console.log('AaveV3PoolBatch', type(AaveV3PoolBatch).creationCode.length);
-    console.log('AaveV3PeripheryBatch', type(AaveV3PeripheryBatch).creationCode.length);
-    console.log('AaveV3MiscBatch', type(AaveV3MiscBatch).creationCode.length);
-    console.log('AaveV3ParaswapBatch', type(AaveV3ParaswapBatch).creationCode.length);
-    console.log('AaveV3GettersBatchOne', type(AaveV3GettersBatchOne).creationCode.length);
-    console.log('AaveV3GettersBatchTwo', type(AaveV3GettersBatchTwo).creationCode.length);
-    console.log('AaveV3TokensBatch', type(AaveV3TokensBatch).creationCode.length);
-    console.log('AaveV3HelpersBatchOne', type(AaveV3HelpersBatchOne).creationCode.length);
-    console.log('AaveV3HelpersBatchTwo', type(AaveV3HelpersBatchTwo).creationCode.length);
-    console.log(
-      'AaveV3PeripheryBatchTreasuryPartner',
-      type(AaveV3PeripheryBatch).creationCode.length
-    );
-
-    assertLe(
-      type(AaveV3SetupBatch).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3SetupBatch max init code size'
-    );
-    assertLe(
-      type(AaveV3L2PoolBatch).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3L2PoolBatch max init code size'
-    );
-    assertLe(
-      type(AaveV3PoolBatch).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3PoolBatch max init code size'
-    );
-    assertLe(
-      type(AaveV3PeripheryBatch).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3PeripheryBatch max init code size'
-    );
-    assertLe(
-      type(AaveV3MiscBatch).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3MiscBatch max init code size'
-    );
-    assertLe(
-      type(AaveV3ParaswapBatch).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3ParaswapBatch max init code size'
-    );
-    assertLe(
-      type(AaveV3GettersBatchOne).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3GettersBatchOne max init code size'
-    );
-    assertLe(
-      type(AaveV3GettersBatchTwo).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3GettersBatchTwo max init code size'
-    );
-    assertLe(
-      type(AaveV3TokensBatch).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3TokensBatch max init code size'
-    );
-    assertLe(
-      type(AaveV3HelpersBatchOne).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3HelpersBatchOne max init code size'
-    );
-    assertLe(
-      type(AaveV3HelpersBatchTwo).creationCode.length,
-      maxInitCodeSize,
-      'AaveV3HelpersBatchTwo max init code size'
-    );
-  }
 }