feat: remove unused functions or variables

Author: Luigy-Lemon

src/contracts/extensions/sgho/interfaces/IsGHO.sol

@@ -30,11 +30,6 @@ interface IsGHO {
    */
   error OnlyYieldManager();
 
-  /**
-   * @notice Thrown if the contract is not initialized.
-   */
-  error NotInitialized();
-
   /**
    * @notice Thrown when an attempt is made to rescue the underlying GHO token.
    */

src/contracts/extensions/sgho/sGHO.sol

@@ -13,7 +13,7 @@ import {ERC20Upgradeable} from 'openzeppelin-contracts-upgradeable/contracts/tok
 
 /**
  * @title sGHO Token
- * @author Luigy-Lemon @kpk
+ * @author @kpk
  * @notice sGHO is an ERC4626 vault that allows users to deposit GHO and earn yield.
  * @dev This contract implements the ERC4626 standard for tokenized vaults, where the underlying asset is GHO.
  * It also includes functionalities for yield generation based on a target rate, and administrative roles for managing the contract.
@@ -30,7 +30,6 @@ contract sGHO is Initializable, ERC4626Upgradeable, ERC20PermitUpgradeable, IsGH
   uint256 public supplyCap;
   uint256 public yieldIndex;
   uint256 public lastUpdate;
-  uint256 internal constant RATE_PRECISION = 1e10;
   uint256 internal constant ONE_YEAR = 365 days;
 
   bytes32 public constant FUNDS_ADMIN_ROLE = 'FUNDS_ADMIN';
@@ -82,17 +81,6 @@ contract sGHO is Initializable, ERC4626Upgradeable, ERC20PermitUpgradeable, IsGH
     revert NoEthAllowed();
   }
 
-  /**
-   * @notice Modifier to check if the contract has been initialized.
-   * @dev Throws if the `initialize` function has not been called.
-   */
-  modifier isInitialized() {
-    if (_getInitializedVersion() == 0) {
-      revert NotInitialized();
-    }
-    _;
-  }
-
   /**
    * @notice Modifier that restricts a function to be called only by an address with the YIELD_MANAGER role.
    * @dev See {_onlyYieldManager}.
@@ -146,13 +134,6 @@ contract sGHO is Initializable, ERC4626Upgradeable, ERC20PermitUpgradeable, IsGH
     return super.nonces(owner);
   }
 
-  /**
-   * @dev See {IERC20Permit-DOMAIN_SEPARATOR}.
-   */
-  function DOMAIN_SEPARATOR() external view virtual override returns (bytes32) {
-    return _domainSeparatorV4();
-  }
-
   function decimals() public view virtual override(ERC20Upgradeable, ERC4626Upgradeable) returns (uint8) {
     return super.decimals();
   }

tests/extensions/sgho/sGHO.t.sol

@@ -1559,21 +1559,7 @@ contract sGhoTest is TestnetProcedures {
     newSgho.initialize(address(gho), address(contracts.aclManager), MAX_TARGET_RATE, SUPPLY_CAP);
   }
 
-  function test_revert_notInitialized() external {
-    // Deploy a new sGHO implementation and proxy without initializing it
-    address impl = address(new sGHO());
-    TransparentUpgradeableProxy proxy = new TransparentUpgradeableProxy(
-      impl,
-      address(this),
-      '' // No initialization data
-    );
-    sGHO uninitializedSgho = sGHO(payable(address(proxy)));
-    
-    // Since the isInitialized modifier is not used by any functions,
-    // we'll test that the contract works correctly when not initialized
-    // The totalAssets should return 0 for an uninitialized contract
-    assertEq(uninitializedSgho.totalAssets(), 0, 'Uninitialized contract should return 0 totalAssets');
-  }
+
 
   // --- Getter Functions Tests ---