fix: Remove unnecessary approval

miguelmtzinf · miguelmtzinf · commit e0b3baa97ea4 · 2024-09-03T10:59:57.000+02:00
diff --git a/src/periphery/contracts/adapters/paraswap/BaseParaSwapBuyAdapter.sol b/src/periphery/contracts/adapters/paraswap/BaseParaSwapBuyAdapter.sol
@@ -76,7 +76,6 @@ abstract contract BaseParaSwapBuyAdapter is BaseParaSwapAdapter {
     uint256 balanceBeforeAssetTo = assetToSwapTo.balanceOf(address(this));
 
     address tokenTransferProxy = augustus.getTokenTransferProxy();
-    assetToSwapFrom.safeApprove(tokenTransferProxy, 0);
     assetToSwapFrom.safeApprove(tokenTransferProxy, maxAmountToSwap);
 
     if (toAmountOffset != 0) {
diff --git a/src/periphery/contracts/adapters/paraswap/BaseParaSwapSellAdapter.sol b/src/periphery/contracts/adapters/paraswap/BaseParaSwapSellAdapter.sol
@@ -98,9 +98,6 @@ abstract contract BaseParaSwapSellAdapter is BaseParaSwapAdapter {
         revert(0, returndatasize())
       }
     }
-    
-    // Reset allowance
-    assetToSwapFrom.safeApprove(tokenTransferProxy, 0);
 
     require(
       assetToSwapFrom.balanceOf(address(this)) == balanceBeforeAssetFrom - amountToSwap,

Original file line number	Diff line number	Diff line change
`@@ -98,9 +98,6 @@ abstract contract BaseParaSwapSellAdapter is BaseParaSwapAdapter {`
`98`	`98`	`revert(0, returndatasize())`
`99`	`99`	`}`
`100`	`100`	`}`
`101`		`-`
`102`		`- // Reset allowance`
`103`		`- assetToSwapFrom.safeApprove(tokenTransferProxy, 0);`
`104`	`101`
`105`	`102`	`require(`
`106`	`103`	`assetToSwapFrom.balanceOf(address(this)) == balanceBeforeAssetFrom - amountToSwap,`