Skip to content

Commit 7f43128

Browse files
committed
fix: Added missing fixes, and lib path updates
1 parent 2ff5d33 commit 7f43128

File tree

7 files changed

+158
-64
lines changed

7 files changed

+158
-64
lines changed

.env.example

Lines changed: 29 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,34 +6,38 @@ LEDGER_SENDER=
66
PRIVATE_KEY=
77

88
# Test rpc_endpoints
9-
RPC_MAINNET=https://eth.llamarpc.com
9+
RPC_MAINNET=https://rpc.flashbots.net
10+
RPC_MAINNET_TESTNET=https://ethereum-sepolia.publicnode.com
1011
RPC_AVALANCHE=https://api.avax.network/ext/bc/C/rpc
11-
RPC_OPTIMISM=https://optimism.llamarpc.com
12-
RPC_POLYGON=https://polygon.llamarpc.com
13-
RPC_ARBITRUM=https://arbitrum.llamarpc.com
12+
RPC_AVALANCHE_TESTNET=https://api.avax.network/ext/bc/C/rpc
13+
RPC_OPTIMISM=https://mainnet.optimism.io
14+
RPC_OPTIMISM_TESTNET=https://mainnet.optimism.io
15+
RPC_POLYGON=https://polygon-rpc.com
16+
RPC_POLYGON_TESTNET=https://polygon-rpc.com
17+
RPC_ARBITRUM=https://arb1.arbitrum.io/rpc
18+
RPC_ARBITRUM_TESTNET=https://arb1.arbitrum.io/rpc
1419
RPC_FANTOM=https://rpc.ftm.tools
20+
RPC_FANTOM_TESTNET=https://rpc.ftm.tools
1521
RPC_HARMONY=https://api.harmony.one
1622
RPC_METIS=https://andromeda.metis.io/?owner=1088
17-
RPC_BASE=https://base.llamarpc.com
18-
RPC_ZKEVM=https://zkevm-rpc.com
19-
RPC_GNOSIS=https://rpc.ankr.com/gnosis
20-
RPC_BNB=https://binance.llamarpc.com
21-
RPC_ZK_SYNC=https://mainnet.era.zksync.io
22-
RPC_ZK_SYNC_TESTNET=https://sepolia.era.zksync.dev
23-
RPC_LINEA=https://rpc.linea.build
24-
RPC_MANTLE=
25-
RPC_MANTLE_TESTNET=
23+
RPC_METIS_TESTNET=https://andromeda.metis.io/?owner=1088
24+
RPC_BINANCE=https://bsc-dataseed.binance.org/
25+
RPC_BINANCE_TESTNET=https://data-seed-prebsc-1-s1.binance.org:8545/
26+
RPC_BASE=https://developer-access-mainnet.base.org
27+
RPC_BASE_TESTNET=https://goerli.base.org
28+
RPC_GNOSIS=https://rpc.gnosischain.com
29+
RPC_GNOSIS_TESTNET=https://rpc.chiadochain.net
30+
RPC_ZKEVM=https://polygon-zkevm.drpc.org
31+
RPC_ZKEVM_TESTNET=https://rpc.public.zkevm-test.net
32+
RPC_SCROLL=https://rpc.scroll.io
33+
RPC_SCROLL_TESTNET=https://sepolia-rpc.scroll.io
34+
RPC_CELO=https://forno.celo.org
35+
RPC_CELO_ALFAJORES=https://alfajores-forno.celo-testnet.org
36+
RPC_ZK_SYNC=https://zksync.drpc.org
37+
RPC_LINEA=https://linea-rpc.publicnode.com
38+
RPC_SONEIUM=https://rpc.soneium.org
39+
RPC_INK=https://ink.drpc.org
40+
RPC_BOB=https://rpc.gobob.xyz
2641

2742
# Etherscan api keys for verification & download utils
28-
ETHERSCAN_API_KEY_MAINNET=
29-
ETHERSCAN_API_KEY_POLYGON=
30-
ETHERSCAN_API_KEY_AVALANCHE=
31-
ETHERSCAN_API_KEY_FANTOM=
32-
ETHERSCAN_API_KEY_OPTIMISM=
33-
ETHERSCAN_API_KEY_ARBITRUM=
34-
ETHERSCAN_API_KEY_BASE=
35-
ETHERSCAN_API_KEY_ZKEVM=
36-
ETHERSCAN_API_KEY_GNOSIS=
37-
ETHERSCAN_API_KEY_BNB=
38-
ETHERSCAN_API_KEY_ZK_SYNC=
39-
ETHERSCAN_API_KEY_MANTLE=
43+
ETHERSCAN_API_KEY=

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[submodule "lib/aave-delivery-infrastructure"]
22
path = lib/aave-delivery-infrastructure
3-
url = https://github.com/bgd-labs/aave-delivery-infrastructure
3+
url = https://github.com/aave-dao/aave-delivery-infrastructure
44
[submodule "lib/aave-helpers"]
55
path = lib/aave-helpers
66
url = https://github.com/bgd-labs/aave-helpers

CONTRIBUTING.ms

Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,90 @@
1+
# Contributing
2+
3+
Thanks for your interest in contributing to aDI Deploy! Please take a moment to review this document **before submitting a pull request.**
4+
5+
## Rules
6+
7+
1. Significant changes to the Protocol must be reviewed before a Pull Request is created. Create a [Feature Request](https://github.com/aave-dao/adi-deploy/issues) first to discuss your ideas.
8+
2. Contributors must be humans, not bots.
9+
3. First time contributions must not contain only spelling or grammatical fixes.
10+
11+
## Basic guide
12+
13+
This guide is intended to help you get started with contributing. By following these steps, you will understand the development process and workflow.
14+
15+
1. [Forking the repository](#forking-the-repository)
16+
2. [Installing Foundry](#installing-foundry)
17+
4. [Installing dependencies](#installing-dependencies)
18+
5. [Running the test suite](#running-the-test-suite)
19+
7. [Submitting a pull request](#submitting-a-pull-request)
20+
21+
---
22+
23+
### Forking the repository
24+
25+
To start contributing to the project, [fork it](https://github.com/aave-dao/adi-deploy) to your private github account.
26+
27+
Once that is done, you can clone your forked repository to your local machine.
28+
```bash
29+
# https
30+
git clone https://github.com/<user>/adi-deploy.git
31+
# ssh
32+
git clone git@github.com:<user>/adi-deploy.git
33+
```
34+
35+
To stay up to date with the main repository, you can add it as a remote.
36+
```bash
37+
# https
38+
git remote add upstream https://github.com/aave-dao/adi-deploy.git
39+
# ssh
40+
git remote add upstream git@github.com:aave-dao/adi-deploy.git
41+
```
42+
43+
---
44+
45+
### Installing foundry
46+
47+
adi Deploy is a [Foundry](https://github.com/foundry-rs/foundry) project.
48+
49+
Install foundry using the following command:
50+
51+
```bash
52+
curl -L https://foundry.paradigm.xyz | bash
53+
```
54+
55+
---
56+
57+
### Installing dependencies
58+
59+
For generating the changelog, linting and testing, we rely on some additional node packages. You can install them by running:
60+
61+
```bash
62+
npm install
63+
```
64+
65+
---
66+
67+
### Running the test suite
68+
69+
For running the default test suite you can use the following command:
70+
71+
```bash
72+
forge test
73+
```
74+
75+
---
76+
77+
### Submitting a pull request
78+
79+
When you're ready to submit a pull request, you can follow these naming conventions:
80+
81+
- Pull request titles use the [Imperative Mood](https://en.wikipedia.org/wiki/Imperative_mood) (e.g., `Add something`, `Fix something`).
82+
- [Changesets](#versioning) use past tense verbs (e.g., `Added something`, `Fixed something`).
83+
84+
When you submit a pull request, GitHub will automatically lint, build, and test your changes. If you see an ❌, it's most likely a bug in your code. Please, inspect the logs through the GitHub UI to find the cause.
85+
86+
- Pull requests must always cover all the changes made with tests. If you're adding a new feature, you must also add a test for it. If you're fixing a bug, you must add a test that reproduces the bug. Pull requests that cause a regression in test coverage will not be accepted.
87+
- Pull requests that touch code functionality should always include updated gas snapshots. Running `forge test` will update the snapshots for you.
88+
- Make sure that your updates are fitting within the existing code margin. You can check by running `forge build --sizes`
89+
90+
---

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Here it can also be found some helper templates to use when creating payloads. F
2929

3030
## License
3131

32-
Copyright © 2024, Aave DAO, represented by its governance smart contracts.
32+
Copyright © 2025, Aave DAO, represented by its governance smart contracts.
3333

3434
Created by [BGD Labs](https://bgdlabs.com/).
3535

foundry.toml

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -70,43 +70,43 @@ soneium="${RPC_SONEIUM}"
7070
bob="${RPC_BOB}"
7171

7272
[etherscan]
73-
ethereum={key="${ETHERSCAN_API_KEY_MAINNET}", chain=1 }
74-
ethereum_testnet={key="${ETHERSCAN_API_KEY_MAINNET}",chain=11155111}
75-
optimism={key="${ETHERSCAN_API_KEY_OPTIMISM}",chain=10}
76-
optimism-testnet={key="${ETHERSCAN_API_KEY_OPTIMISM}",chain=10}
77-
avalanche={key="${ETHERSCAN_API_KEY_AVALANCHE}",chain=43114}
78-
avalanche-testnet={key="${ETHERSCAN_API_KEY_AVALANCHE}",chain=43113}
79-
polygon={key="${ETHERSCAN_API_KEY_POLYGON}",chain=137}
80-
polygon-testnet={key="${ETHERSCAN_API_KEY_POLYGON}",chain=80001}
81-
arbitrum={key="${ETHERSCAN_API_KEY_ARBITRUM}",chain=42161}
82-
arbitrum_sepolia={key="${ETHERSCAN_API_KEY_ARBITRUM}",chain=42161}
73+
ethereum={key="${ETHERSCAN_API_KEY}", chain=1 }
74+
ethereum_testnet={key="${ETHERSCAN_API_KEY}",chain=11155111}
75+
optimism={key="${ETHERSCAN_API_KEY}",chain=10}
76+
optimism-testnet={key="${ETHERSCAN_API_KEY}",chain=10}
77+
avalanche={key="${ETHERSCAN_API_KEY}",chain=43114}
78+
avalanche-testnet={key="${ETHERSCAN_API_KEY}",chain=43113}
79+
polygon={key="${ETHERSCAN_API_KEY}",chain=137}
80+
polygon-testnet={key="${ETHERSCAN_API_KEY}",chain=80001}
81+
arbitrum={key="${ETHERSCAN_API_KEY}",chain=42161}
82+
arbitrum_sepolia={key="${ETHERSCAN_API_KEY}",chain=42161}
8383
metis={ key="any", chain=1088, url='https://andromeda-explorer.metis.io/' }
8484
metis-testnet={ key="any", chain=599, url='https://goerli.explorer.metisdevops.link/' }
85-
fantom={key="${ETHERSCAN_API_KEY_FANTOM}",chain=250}
86-
fantom-testnet={key="${ETHERSCAN_API_KEY_FANTOM}",chain=250}
87-
binance={key="${ETHERSCAN_API_KEY_BNB}",chain=56}
88-
binance-testnet={key="${ETHERSCAN_API_KEY_BNB}",chain=97}
89-
base={key="${ETHERSCAN_API_KEY_BASE}",chain=8453, url='https://developer-access-mainnet.base.org'}
90-
base-testnet={key="${ETHERSCAN_API_KEY_BASE}",chain=8453, url='https://developer-access-mainnet.base.org'}
91-
gnosis={key="${ETHERSCAN_API_KEY_GNOSIS}",chain=100}
92-
gnosis-testnet={key="${ETHERSCAN_API_KEY_GNOSIS}",chain=10200, url='https://gnosis-chiado.blockscout.com/'}
93-
zkevm={key="${ETHERSCAN_API_KEY_ZKEVM}",chain=1101}
94-
zkevm-testnet={key="${ETHERSCAN_API_KEY_ZKEVM}",chain=1442}
95-
scroll={key="${ETHERSCAN_API_KEY_SCROLL}", chain=534352, utl='https://api.scrollscan.com/api/'}
96-
scroll-testnet={key="${ETHERSCAN_API_KEY_SCROLL}", chain=534351, url='https://api-sepolia.scrollscan.com/api/'}
97-
celo={key="${ETHERSCAN_API_KEY_CELO}", chain=42220, utl='https://api.celoscan.io/api'}
98-
celo-testnet={key="${ETHERSCAN_API_KEY_CELO}", chain=44787, url='https://api-alfajores.celoscan.io/api'}
99-
zksync={key="${ETHERSCAN_API_KEY_ZK_SYNC}", chain=324}
100-
zksync-testnet={key="${ETHERSCAN_API_KEY_ZK_SYNC}", chain=300, url='https://api-sepolia-era.zksync.network/api'}
101-
linea={key="${ETHERSCAN_API_KEY_LINEA}", chain=59144 }
102-
linea-testnet={key="${ETHERSCAN_API_KEY_LINEA}",chain=59141}
103-
sonic={key="${ETHERSCAN_API_KEY_SONIC}", chain=146, url='https://api.sonicscan.org/api'}
104-
sonic-testnet={key="${ETHERSCAN_API_KEY_SONIC}", chain=57054, url='https://api-testnet.sonicscan.org/api'}
105-
mantle={key="${ETHERSCAN_API_KEY_MANTLE}", chain=5000, url='https://api.mantlescan.xyz/api'}
106-
mantle-testnet={key="${ETHERSCAN_API_KEY_MANTLE}", chain=5003, url='https://explorer.testnet.mantle.xyz/api'}
107-
ink={key="${ETHERSCAN_API_KEY_INK}", chain=57073, url='https://api.routescan.io/v2/network/mainnet/evm/57073/etherscan'}
108-
soneium={key="${ETHERSCAN_API_KEY_SONEIUM}", chain=1868, url='https://soneium.blockscout.com/api/'}
109-
bob={key="${ETHERSCAN_API_KEY_BOB}", chain=60808, url='https://explorer.gobob.xyz/api/'}
85+
fantom={key="${ETHERSCAN_API_KEY}",chain=250}
86+
fantom-testnet={key="${ETHERSCAN_API_KEY}",chain=250}
87+
binance={key="${ETHERSCAN_API_KEY}",chain=56}
88+
binance-testnet={key="${ETHERSCAN_API_KEY}",chain=97}
89+
base={key="${ETHERSCAN_API_KEY}",chain=8453, url='https://developer-access-mainnet.base.org'}
90+
base-testnet={key="${ETHERSCAN_API_KEY}",chain=8453, url='https://developer-access-mainnet.base.org'}
91+
gnosis={key="${ETHERSCAN_API_KEY}",chain=100}
92+
gnosis-testnet={key="${ETHERSCAN_API_KEY}",chain=10200, url='https://gnosis-chiado.blockscout.com/'}
93+
zkevm={key="${ETHERSCAN_API_KEY}",chain=1101}
94+
zkevm-testnet={key="${ETHERSCAN_API_KEY}",chain=1442}
95+
scroll={key="${ETHERSCAN_API_KEY}", chain=534352, utl='https://api.scrollscan.com/api/'}
96+
scroll-testnet={key="${ETHERSCAN_API_KEY}", chain=534351, url='https://api-sepolia.scrollscan.com/api/'}
97+
celo={key="${ETHERSCAN_API_KEY}", chain=42220, utl='https://api.celoscan.io/api'}
98+
celo-testnet={key="${ETHERSCAN_API_KEY}", chain=44787, url='https://api-alfajores.celoscan.io/api'}
99+
zksync={key="${ETHERSCAN_API_KEY}", chain=324}
100+
zksync-testnet={key="${ETHERSCAN_API_KEY}", chain=300, url='https://api-sepolia-era.zksync.network/api'}
101+
linea={key="${ETHERSCAN_API_KEY}", chain=59144 }
102+
linea-testnet={key="${ETHERSCAN_API_KEY}",chain=59141}
103+
sonic={key="${ETHERSCAN_API_KEY}", chain=146, url='https://api.sonicscan.org/api'}
104+
sonic-testnet={key="${ETHERSCAN_API_KEY}", chain=57054, url='https://api-testnet.sonicscan.org/api'}
105+
mantle={key="${ETHERSCAN_API_KEY}", chain=5000, url='https://api.mantlescan.xyz/api'}
106+
mantle-testnet={key="${ETHERSCAN_API_KEY}", chain=5003, url='https://explorer.testnet.mantle.xyz/api'}
107+
ink={key="${ETHERSCAN_API_KEY}", chain=57073, url='https://api.routescan.io/v2/network/mainnet/evm/57073/etherscan'}
108+
soneium={key="${ETHERSCAN_API_KEY}", chain=1868, url='https://soneium.blockscout.com/api/'}
109+
bob={key="${ETHERSCAN_API_KEY}", chain=60808, url='https://explorer.gobob.xyz/api/'}
110110

111111
# See more config options https://github.com/gakonst/foundry/tree/master/config
112112
[fuzz]

lib/aave-delivery-infrastructure

scripts/BaseDeployerScript.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ library DeployerHelpers {
4545

4646
function getPathByChainId(uint256 chainId) internal pure returns (string memory) {
4747
string memory path = string.concat(
48-
'./deployments/cc/mainnet/',
48+
'./deployments/cc/mainnet/', // @dev important to maintain this folder structure as governance uses this path to get the adi addresses
4949
ChainHelpers.getNetworkNameFromId(chainId)
5050
);
5151
return string.concat(path, '.json');

0 commit comments

Comments
 (0)