Skip to content

Commit 1574756

Browse files
feat: OZ v5.3 dependency removed, keeping v4.7 only instead
1 parent 0b87564 commit 1574756

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

.gitmodules

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
[submodule "lib/openzeppelin-contracts"]
88
path = lib/openzeppelin-contracts
99
url = https://github.com/OpenZeppelin/openzeppelin-contracts
10+
branch = v4.7.0
1011
[submodule "lib/aave-v3-core"]
1112
path = lib/aave-v3-core
1213
url = https://github.com/aave/aave-v3-core
@@ -25,7 +26,3 @@
2526
[submodule "lib/createx"]
2627
path = lib/createx
2728
url = https://github.com/pcaversaccio/createx
28-
[submodule "lib/openzeppelin-contracts-v5.3.0"]
29-
path = lib/openzeppelin-contracts-v5.3.0
30-
url = https://github.com/openzeppelin/openzeppelin-contracts
31-
branch = v5.3.0

lib/openzeppelin-contracts-v5.3.0

Lines changed: 0 additions & 1 deletion
This file was deleted.

script/DeployFactory.s.sol

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ pragma solidity ^0.8.10;
55
import "forge-std/Script.sol";
66
import {ATokenVaultFactory} from "../src/ATokenVaultFactory.sol";
77
import {ICreateX} from "@pcaversaccio/createx/ICreateX.sol";
8-
import {ProxyAdmin as ProxyAdmin_v4_7} from "@openzeppelin/proxy/transparent/ProxyAdmin.sol";
9-
import {TransparentUpgradeableProxy as TransparentUpgradeableProxy_v5_3} from "@openzeppelin-v5/proxy/transparent/TransparentUpgradeableProxy.sol";
8+
import {ProxyAdmin} from "@openzeppelin/proxy/transparent/ProxyAdmin.sol";
9+
import {TransparentUpgradeableProxy} from "@openzeppelin/proxy/transparent/TransparentUpgradeableProxy.sol";
1010

1111
/**
1212
* @title DeployFactory
@@ -21,9 +21,9 @@ import {TransparentUpgradeableProxy as TransparentUpgradeableProxy_v5_3} from "@
2121
contract DeployFactory is Script {
2222
/////////////////// DEPLOYMENT PARAMETERS //////////////////////////
2323
/**
24-
* @notice Owner of the aTokenVaultFactory's Proxy Admin
24+
* @notice The aTokenVaultFactory's Proxy Admin
2525
*/
26-
address constant FACTORY_PROXY_ADMIN_OWNER = address(0);
26+
address constant FACTORY_PROXY_ADMIN = address(0);
2727
////////////////////////////////////////////////////////////////////
2828

2929
address constant EXPECTED_FACTORY_ADDRESS = address(0xa35995bb2fFC5F2b33379C2e95d00C20FbF71E70);
@@ -67,22 +67,22 @@ contract DeployFactory is Script {
6767

6868
console.log("ChainId: ", block.chainid);
6969

70-
require(FACTORY_PROXY_ADMIN_OWNER != address(0), "FACTORY_PROXY_ADMIN_OWNER is not set");
71-
console.log("Factory proxy admin owner: ", FACTORY_PROXY_ADMIN_OWNER);
70+
require(FACTORY_PROXY_ADMIN != address(0), "FACTORY_PROXY_ADMIN is not set");
71+
console.log("Factory proxy admin owner: ", FACTORY_PROXY_ADMIN);
7272

7373

7474
vm.startBroadcast();
7575

7676

77-
/////// Deploy Renounced ProxyAdmin (using OpenZeppelin v4.7)
77+
/////// Deploy Renounced ProxyAdmin
7878

7979
console.log("Deploying vault's renounced proxy admin");
8080

81-
address renouncedProxyAdmin = address(new ProxyAdmin_v4_7());
81+
address renouncedProxyAdmin = address(new ProxyAdmin());
8282

8383
console.log("Renounced proxy admin deployed at: ", renouncedProxyAdmin);
8484

85-
ProxyAdmin_v4_7(renouncedProxyAdmin).renounceOwnership();
85+
ProxyAdmin(renouncedProxyAdmin).renounceOwnership();
8686

8787

8888
/////// Deploy aTokenVaultFactory Implementation (pass Renounced ProxyAdmin as argument)
@@ -95,15 +95,15 @@ contract DeployFactory is Script {
9595

9696

9797

98-
/////// Deploy aTokenVaultFactory Proxy (using OpenZeppelin v5.3)
98+
/////// Deploy aTokenVaultFactory Proxy
9999

100100
console.log("Deploying aTokenVaultFactory proxy - Expected at: ", address(EXPECTED_FACTORY_ADDRESS));
101101

102102
address factoryProxy = CREATE3_FACTORY.deployCreate3({
103103
salt: FACTORY_SALT,
104104
initCode: abi.encodePacked(
105-
type(TransparentUpgradeableProxy_v5_3).creationCode,
106-
abi.encode(factoryImplementation, FACTORY_PROXY_ADMIN_OWNER, "")
105+
type(TransparentUpgradeableProxy).creationCode,
106+
abi.encode(factoryImplementation, FACTORY_PROXY_ADMIN, "")
107107
)
108108
});
109109

0 commit comments

Comments
 (0)