Skip to content

Commit 44e25a1

Browse files
feat: Mark functions as virtual & remove unnecessary super._disableInitializers call
1 parent 86bff4c commit 44e25a1

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/ImmutableATokenVault.sol

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,19 @@ contract ImmutableATokenVault is ATokenVault {
4747
shareSymbol,
4848
initialLockDeposit
4949
);
50-
super._disableInitializers();
5150
}
5251

52+
/**
53+
* @dev Initializes the contract given that the base contract, ATokenVault, uses upgradable contracts.
54+
*/
5355
function _initialize(
5456
address underlying,
5557
address owner,
5658
uint256 initialFee,
5759
string memory shareName,
5860
string memory shareSymbol,
5961
uint256 initialLockDeposit
60-
) internal initializer {
62+
) internal virtual initializer {
6163
require(owner != address(0), "ZERO_ADDRESS_NOT_VALID");
6264
require(initialLockDeposit != 0, "ZERO_INITIAL_LOCK_DEPOSIT");
6365
_transferOwnership(owner);
@@ -74,5 +76,5 @@ contract ImmutableATokenVault is ATokenVault {
7476
* This turns the `_disableInitializers` call in ATokenVault's constructor ineffective,
7577
* allowing initialization at the ImmutableATokenVault's constructor.
7678
*/
77-
function _disableInitializers() internal override { }
79+
function _disableInitializers() internal virtual override { }
7880
}

0 commit comments

Comments
 (0)