feat: VaultParams added into VaultDeployed event

Author: donosonaumczuk

src/ATokenVaultFactory.sol

@@ -45,16 +45,14 @@ contract ATokenVaultFactory {
      * @param implementation The address of the vault implementation
      * @param underlying The underlying asset address
      * @param deployer The address that deployed the vault
-     * @param owner The owner of the vault
+     * @param params The parameters used to deploy the vault
      */
     event VaultDeployed(
         address indexed vault,
         address indexed implementation,
         address indexed underlying,
         address deployer,
-        address owner,
-        uint16 referralCode,
-        address poolAddressesProvider
+        VaultParams params
     );
 
     /*//////////////////////////////////////////////////////////////
@@ -164,9 +162,7 @@ contract ATokenVaultFactory {
             implementation,
             params.underlying,
             msg.sender,
-            params.owner,
-            params.referralCode,
-            address(params.poolAddressesProvider)
+            params
         );
     }
 

test/ATokenVaultFactory.t.sol

@@ -219,25 +219,32 @@ contract ATokenVaultFactoryTest is Test {
         // Find the VaultDeployed event (should be the last one)
         bool eventFound = false;
         for (uint i = 0; i < logs.length; i++) {
-            if (logs[i].topics[0] == keccak256("VaultDeployed(address,address,address,address,address,uint16,address)")) {
+            if (logs[i].topics[0] == keccak256("VaultDeployed(address,address,address,address,(address,uint16,address,address,uint256,string,string,uint256))")) {
                 eventFound = true;
 
                 // Decode the event data
                 address eventVault = address(uint160(uint256(logs[i].topics[1])));
                 address eventImplementation = address(uint160(uint256(logs[i].topics[2])));
                 address eventUnderlying = address(uint160(uint256(logs[i].topics[3])));
 
-                (address eventDeployer, address eventOwner, uint16 eventReferralCode, address eventPoolProvider) =
-                                    abi.decode(logs[i].data, (address, address, uint16, address));
+                (address eventDeployer, ATokenVaultFactory.VaultParams memory eventVaultParams) = abi.decode(
+                    logs[i].data,
+                    (address, ATokenVaultFactory.VaultParams)
+                );
 
                 // Verify event data
                 assertEq(eventVault, vault);
                 assertTrue(eventImplementation != address(0));
                 assertEq(eventUnderlying, address(dai));
                 assertEq(eventDeployer, ALICE);
-                assertEq(eventOwner, ALICE);
-                assertEq(eventReferralCode, 42);
-                assertEq(eventPoolProvider, address(poolAddrProvider));
+                assertEq(eventVaultParams.underlying, address(dai));
+                assertEq(eventVaultParams.referralCode, 42);
+                assertEq(address(eventVaultParams.poolAddressesProvider), address(poolAddrProvider));
+                assertEq(eventVaultParams.owner, ALICE);
+                assertEq(eventVaultParams.initialFee, 0);
+                assertEq(eventVaultParams.shareName, "Test Vault");
+                assertEq(eventVaultParams.shareSymbol, "tVault");
+                assertEq(eventVaultParams.initialLockDeposit, initialDeposit);
                 break;
             }
         }