Skip to content

Conversation

@donosonaumczuk
Copy link
Member

@donosonaumczuk donosonaumczuk commented Jul 17, 2025

"Fees/rewards already accrued cannot be taken from the configured recipients, i.e. cannot be stopped to be distributed to them using the corresponding configured shares."

Features:

  • It claims fees and rewards to address(this). No input params required.
    Given that restricted behaviour, anyone can call the reward/fee claims and the split revenue functions (removes dependency on the owner).
  • Shares are limited to Basis Points (BPS) so it is less error prone (than allowing any custom shares and using their sum).
  • Changing the fee does not rug previous fees/rewards, liquidity can be withdrawn if disagreed with new fee set by the owner.
  • Transferring the vault ownership will claim fees and rewards first, so already accrued fees/rewards cannot be stolen by the owner.
    After the ownership transfer is done, liquidity can be withdrawn if the new setup is undesired.
  • Recipients and their shares can only be set at construction time (to modify this, creating a new splitter and transferring ownership to it will be needed).

Observation:

  • Emergency rescue does not work for aToken (fees are claimed in aToken), and rewards are not held by the vault itself. Thus, the emergency rescue cannot be used to rug by "rescuing" fees or rewards.

@donosonaumczuk donosonaumczuk changed the title feat: aToken Vault Revenut-Splitter Owner feat: aToken Vault Revenue-Splitter Owner Jul 18, 2025
@donosonaumczuk donosonaumczuk marked this pull request as ready for review July 18, 2025 17:38
@joshstevens19 joshstevens19 merged commit 01e3f45 into main Aug 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants