[WIP] feat: init impl for AssetListingStewards scripts/tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-man
changed the title
Comment on lines
+22
to
+30
| function GUARDIAN() public virtual returns (address) { | ||
| return HorizonAddresses.HORIZON_ADVANCED_MULTISIG; | ||
| } | ||
| function PAYLOADS_MANAGER() public virtual returns (address) { | ||
| return HorizonAddresses.HORIZON_ADVANCED_MULTISIG; | ||
| } | ||
| function PERMISSIONED_EXECUTOR() public virtual returns (address) { | ||
| return HorizonAddresses.EXECUTOR; | ||
| } |
Collaborator
There was a problem hiding this comment.
why are they public? i think these can be internal, or completely removed
|
|
||
| function run(address proxyFactory) public { | ||
| vm.startBroadcast(); | ||
| _execute(proxyFactory); |
Collaborator
There was a problem hiding this comment.
we can set the proxy factory to use in a constant
| proxyFactory | ||
| ).createDeterministic( | ||
| permissionedPayloadsControllerImpl, | ||
| PERMISSIONED_EXECUTOR(), // owner of proxy that will be deployed |
Collaborator
There was a problem hiding this comment.
better to deploy a proxy admin contract. This proxy factory does not do it, but other versions do
| { | ||
| return | ||
| IEngine.PoolContext({ | ||
| networkName: 'Horizon RWA', |
Collaborator
There was a problem hiding this comment.
do we need Aave here? Aave Horizon RWA
Collaborator
Author
There was a problem hiding this comment.
i'll double check and match w whatever Alex has for phase1
Comment on lines
+92
to
+93
| ACLManager(ACL_MANAGER).renounceRole(RISK_ADMIN_ROLE, address(this)); | ||
| ACLManager(ACL_MANAGER).renounceRole( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.