fix: update snapshots and assertions for tests (#125)

Author: juangm

packages/spec/markets/__snapshots__/chains.spec.ts.snap

@@ -192,7 +192,7 @@ describe('Given an Aave Market', () => {
           );
         assertOk(result);
         expect(result.value.length).toBe(1);
-        expect(Number(result.value[0]?.debt.amount.value)).toBeCloseTo(
+        expect(result.value[0]?.debt.amount.value).toBeBigDecimalCloseTo(
           Number(userBorrowsBefore.value[0]?.debt.amount.value) * 0.5,
           4,
         );

packages/spec/markets/repay.spec.ts

@@ -265,7 +265,7 @@ describe('Given an Aave Market', () => {
           evmAddress(anotherUser.account!.address),
           ETHEREUM_WETH_ADDRESS,
         );
-        expect(balance).toBeCloseTo(Number(suppliedAmount), 3);
+        expect(balance).toBeBigDecimalCloseTo(suppliedAmount, 3);
       });
     });
 

packages/spec/markets/withdraw.spec.ts

@@ -92,6 +92,15 @@ exports[`Given the Aave Protocol > When listing all supported chains > Then it s
     "name": "Base",
     "nativeWrappedToken": "0x4200000000000000000000000000000000000006",
   },
+  {
+    "__typename": "Chain",
+    "chainId": 9745,
+    "explorerUrl": "https://plasmascan.to/",
+    "icon": "https://statics.aave.com/plasma.svg",
+    "isTestnet": false,
+    "name": "Plasma",
+    "nativeWrappedToken": "0x6100E367285b01F48D07953803A2d8dCA5D19873",
+  },
   {
     "__typename": "Chain",
     "chainId": 42161,

packages/spec/misc/__snapshots__/chains.spec.ts.snap

@@ -397,13 +397,13 @@ describe('Given the Aave Vaults', () => {
         });
         assertOk(vaultInfoBefore);
         annotate(
-          `totalFeeRevenue: ${Number(
-            vaultInfoBefore.value?.totalFeeRevenue.amount.value,
-          )}`,
+          `totalFeeRevenue: ${
+            vaultInfoBefore.value?.totalFeeRevenue.amount.value
+          }`,
         );
         expect(
-          Number(vaultInfoBefore.value?.totalFeeRevenue.amount.value),
-        ).toBeGreaterThan(0);
+          vaultInfoBefore.value?.totalFeeRevenue.amount.value,
+        ).toBeBigDecimalGreaterThan('0');
         const balanceBefore = await getBalance(
           evmAddress(organization.account!.address),
           initialVault.value?.usedReserve.aToken.address,
@@ -425,9 +425,7 @@ describe('Given the Aave Vaults', () => {
           initialVault.value?.usedReserve.aToken.address,
         );
         annotate(`balance after: ${balanceAfter}`);
-        expect(balanceAfter * 10 ** 18).toBeGreaterThan(
-          balanceBefore * 10 ** 18,
-        );
+        expect(balanceAfter).toBeGreaterThan(balanceBefore);
       }, 60_000);
     });
 
@@ -609,13 +607,9 @@ describe('Given the Aave Vaults', () => {
 
       assertOk(listOfVaultsDesc);
       expect(
-        Number(
-          listOfVaultsDesc.value.items[0]!.userShares!.shares.amount.value,
-        ),
-      ).toBeGreaterThanOrEqual(
-        Number(
-          listOfVaultsDesc.value.items[1]!.userShares!.shares.amount.value,
-        ),
+        listOfVaultsDesc.value.items[0]!.userShares!.shares.amount.raw,
+      ).toBeBigDecimalGreaterThan(
+        listOfVaultsDesc.value.items[1]!.userShares!.shares.amount.raw,
       );
 
       const listOfVaultsAsc = await userVaults(client, {
@@ -625,9 +619,9 @@ describe('Given the Aave Vaults', () => {
 
       assertOk(listOfVaultsAsc);
       expect(
-        Number(listOfVaultsAsc.value.items[0]!.userShares!.shares.amount.value),
-      ).toBeLessThanOrEqual(
-        Number(listOfVaultsAsc.value.items[1]!.userShares!.shares.amount.value),
+        listOfVaultsAsc.value.items[1]!.userShares!.shares.amount.raw,
+      ).toBeBigDecimalGreaterThan(
+        listOfVaultsAsc.value.items[0]!.userShares!.shares.amount.raw,
       );
     });
 
@@ -642,10 +636,8 @@ describe('Given the Aave Vaults', () => {
 
       assertOk(listOfVaultsDesc);
       expect(
-        Number(listOfVaultsDesc.value.items[0]?.fee.value),
-      ).toBeGreaterThanOrEqual(
-        Number(listOfVaultsDesc.value.items[1]?.fee.value),
-      );
+        listOfVaultsDesc.value.items[0]?.fee.value,
+      ).toBeBigDecimalGreaterThan(listOfVaultsDesc.value.items[1]?.fee.value);
 
       const listOfVaultsAsc = await userVaults(client, {
         user: evmAddress(user.account!.address),
@@ -654,8 +646,8 @@ describe('Given the Aave Vaults', () => {
 
       assertOk(listOfVaultsAsc);
       expect(
-        Number(listOfVaultsAsc.value.items[0]?.fee.value),
-      ).toBeLessThanOrEqual(Number(listOfVaultsAsc.value.items[1]?.fee.value));
+        listOfVaultsAsc.value.items[1]?.fee.value,
+      ).toBeBigDecimalGreaterThan(listOfVaultsAsc.value.items[0]?.fee.value);
     });
 
     it('Then it should be possible so filter them by underlying tokens', async ({

packages/spec/vaults/vaults.spec.ts

@@ -4,6 +4,7 @@ declare module 'vitest' {
   interface AsymmetricMatchersContaining extends JestExtendedMatchers {
     toBeBigDecimalCloseTo: (expected: number | string, precision?: number) => R;
     toBeBigDecimalWithin: (start: number | string, end: number | string) => R;
+    toBeBigDecimalGreaterThan: (expected: number | string) => R;
     toBeBetweenDates: (start: Date, end: Date) => R;
     toBeHexString: () => R;
   }

vitest.d.ts

@@ -38,6 +38,18 @@ expect.extend({
     };
   },
 
+  toBeBigDecimalGreaterThan(received: string, expected: number | string) {
+    const numValue = Number(received);
+    const pass = !Number.isNaN(numValue) && numValue > Number(expected);
+    return {
+      pass,
+      message: () =>
+        pass
+          ? `expected "${received}" not to be greater than ${expected}`
+          : `expected "${received}" to be greater than ${expected}, but got ${numValue}`,
+    };
+  },
+
   toBeBetweenDates(received: string, start: Date, end: Date) {
     const receivedDate = new Date(received);
     const pass =