fix: clean up param registry naming; horizon addrs deps

Author: yan-man

scripts/misc/DeployHorizonPhaseTwoPayload.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: BUSL-1.1
 pragma solidity ^0.8.0;
 
-import {AaveV3HorizonEthereum} from 'tests/horizon/utils/AaveV3HorizonEthereum.sol';
+import {AaveV3EthereumHorizonCustom} from 'tests/horizon/utils/AaveV3EthereumHorizonCustom.sol';
 import {HorizonPhaseTwoListing} from 'src/deployments/inputs/HorizonPhaseTwoListing.sol';
 import {AaveV3HelpersBatchOne} from 'src/deployments/projects/aave-v3-batched/batches/AaveV3HelpersBatchOne.sol';
 import {AaveV3ConfigEngine} from 'src/contracts/extensions/v3-config-engine/AaveV3ConfigEngine.sol';
@@ -11,14 +11,14 @@ contract DeployHorizonPhaseTwoPayload is Script {
   function run() public returns (address, address) {
     vm.startBroadcast();
     AaveV3HelpersBatchOne helpersBatchOne = new AaveV3HelpersBatchOne(
-      AaveV3HorizonEthereum.POOL,
-      AaveV3HorizonEthereum.POOL_CONFIGURATOR,
-      AaveV3HorizonEthereum.DEFAULT_INTEREST_RATE_STRATEGY,
-      AaveV3HorizonEthereum.AAVE_ORACLE,
-      AaveV3HorizonEthereum.REWARDS_CONTROLLER,
-      AaveV3HorizonEthereum.REVENUE_SPLITTER,
-      AaveV3HorizonEthereum.ATOKEN_IMPLEMENTATION,
-      AaveV3HorizonEthereum.VARIABLE_DEBT_TOKEN_IMPLEMENTATION
+      AaveV3EthereumHorizonCustom.POOL,
+      AaveV3EthereumHorizonCustom.POOL_CONFIGURATOR,
+      AaveV3EthereumHorizonCustom.DEFAULT_INTEREST_RATE_STRATEGY,
+      AaveV3EthereumHorizonCustom.AAVE_ORACLE,
+      AaveV3EthereumHorizonCustom.REWARDS_CONTROLLER,
+      AaveV3EthereumHorizonCustom.REVENUE_SPLITTER,
+      AaveV3EthereumHorizonCustom.ATOKEN_IMPLEMENTATION,
+      AaveV3EthereumHorizonCustom.VARIABLE_DEBT_TOKEN_IMPLEMENTATION
     );
 
     HorizonPhaseTwoListing horizonPhaseTwoListing = new HorizonPhaseTwoListing(

tests/deployments/HorizonBase.t.sol

@@ -25,7 +25,7 @@ import {IPool} from '../../src/contracts/interfaces/IPool.sol';
 import {IPoolConfigurator} from '../../src/contracts/interfaces/IPoolConfigurator.sol';
 import {Errors} from '../../src/contracts/protocol/libraries/helpers/Errors.sol';
 import {ProxyHelpers} from '../utils/ProxyHelpers.sol';
-import {IParameterRegistry} from '../horizon/dependencies/IParameterRegistry.sol';
+import {IRwaOracleParameterRegistry} from '../horizon/dependencies/IRwaOracleParameterRegistry.sol';
 import {AaveV3EthereumHorizonCustom} from '../horizon/utils/AaveV3EthereumHorizonCustom.sol';
 
 abstract contract HorizonBaseTest is Test {

tests/deployments/HorizonPhaseTwoListing.t.sol

@@ -80,9 +80,8 @@ contract HorizonPhaseTwoListingTest is HorizonBaseTest {
 
   function test_param_registry_VBILL() public {
     assertEq(
-      IParameterRegistry(AaveV3EthereumHorizonCustom.RWA_ORACLE_PARAMS_REGISTRY).assetExists(
-        AaveV3EthereumHorizonCustom.VBILL_UNDERLYING
-      ),
+      IRwaOracleParameterRegistry(AaveV3EthereumHorizonCustom.RWA_ORACLE_PARAMS_REGISTRY)
+        .assetExists(AaveV3EthereumHorizonCustom.VBILL_UNDERLYING),
       true,
       'assetExists'
     );

tests/horizon/OracleDynamicBounds.t.sol

@@ -10,7 +10,7 @@ import {AggregatorInterface} from '../../src/contracts/dependencies/chainlink/Ag
 
 import {AaveV3EthereumHorizonCustom} from './utils/AaveV3EthereumHorizonCustom.sol';
 
-import {IParameterRegistry} from './dependencies/IParameterRegistry.sol';
+import {IRwaOracleParameterRegistry} from './dependencies/IRwaOracleParameterRegistry.sol';
 
 abstract contract OracleDynamicBoundsTestBase is Test {
   address constant USTB_NEW_AGGREGATOR = 0x267D0DD05fbc989565C521e0B8882f61027FF32A;
@@ -39,9 +39,11 @@ abstract contract OracleDynamicBoundsTestBase is Test {
   mapping(address => NewAggregator) internal newAggregators; // asset => new aggregator
 
   IAaveOracle internal aaveOracle;
-  IParameterRegistry internal parameterRegistry;
+  IRwaOracleParameterRegistry internal parameterRegistry;
   function setUp() public virtual {
-    parameterRegistry = IParameterRegistry(AaveV3EthereumHorizonCustom.RWA_ORACLE_PARAMS_REGISTRY);
+    parameterRegistry = IRwaOracleParameterRegistry(
+      AaveV3EthereumHorizonCustom.RWA_ORACLE_PARAMS_REGISTRY
+    );
   }
 
   function test_asset(address asset, address oracleSource, bool isAdapter) internal {

tests/horizon/dependencies/IParameterRegistry.sol renamed to tests/horizon/dependencies/IRwaOracleParameterRegistry.sol

@@ -2,7 +2,7 @@
 pragma solidity ^0.8.0;
 
 /// @dev minimal interface for the Llama Risk RWA Oracle parameter registry
-interface IParameterRegistry {
+interface IRwaOracleParameterRegistry {
   function assetExists(address asset) external view returns (bool);
 
   function getParametersForAsset(