Skip to content

Commit 96dda27

Browse files
committed
test: clean up latestRoundData bounds
1 parent 2e91d4f commit 96dda27

File tree

1 file changed

+11
-21
lines changed

1 file changed

+11
-21
lines changed

tests/horizon/OracleDynamicBounds.t.sol

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -280,21 +280,21 @@ contract OracleDynamicBoundsTest is Test {
280280
uint80 answeredInRound
281281
) = abi.decode(data, (uint80, int256, uint256, uint256, uint80));
282282

283-
assertGt(roundId, 0, 'roundId');
284-
assertGt(answer, 0, 'answer');
285-
assertApproxEqRel(
283+
assertGt(roundId, 0, 'lookback roundId');
284+
assertGt(answer, 0, 'lookback answer');
285+
assertApproxEqAbs(
286286
startedAt,
287287
vm.getBlockTimestamp() - expectedParams[asset].lookbackWindowSize * 1 days, // within expected lookback window
288-
1e15,
289-
'startedAt'
288+
1 days * 1.5, // account for differences in update times throughout the day
289+
'lookback startedAt'
290290
);
291-
assertApproxEqRel(
291+
assertApproxEqAbs(
292292
updatedAt,
293293
vm.getBlockTimestamp() - expectedParams[asset].lookbackWindowSize * 1 days, // within expected lookback window
294-
1e15,
295-
'updatedAt'
294+
1 days * 1.5, // account for differences in update times throughout the day
295+
'lookback updatedAt'
296296
);
297-
assertGt(answeredInRound, 0, 'answeredInRound');
297+
assertGt(answeredInRound, 0, 'lookback answeredInRound');
298298
}
299299

300300
function test_new_aggregator(address asset) internal {
@@ -311,18 +311,8 @@ contract OracleDynamicBoundsTest is Test {
311311

312312
assertGt(roundId, expectedParams[asset].lookbackWindowSize, 'roundId');
313313
assertGt(answer, 0, 'answer');
314-
assertApproxEqRel(
315-
startedAt,
316-
vm.getBlockTimestamp() - expectedParams[asset].lookbackWindowSize * 1 days, // within expected lookback window
317-
1e15,
318-
'startedAt'
319-
);
320-
assertApproxEqRel(
321-
updatedAt,
322-
vm.getBlockTimestamp() - expectedParams[asset].lookbackWindowSize * 1 days, // within expected lookback window
323-
1e15,
324-
'updatedAt'
325-
);
314+
assertApproxEqAbs(startedAt, vm.getBlockTimestamp(), 1 days, 'startedAt');
315+
assertApproxEqAbs(updatedAt, vm.getBlockTimestamp(), 1 days, 'updatedAt');
326316
assertGt(answeredInRound, expectedParams[asset].lookbackWindowSize, 'answeredInRound');
327317
}
328318

0 commit comments

Comments
 (0)