feat: liquidation data provider deployment script #32

yan-man · 2025-09-04T01:57:53Z

deployment scripts for liquidation data provider
skip prior phase one listing tests to resolve CI
resolve certora CI

github-actions · 2025-09-04T01:58:26Z

certora-run

Verification Results

Group ID: 54fbba69-5b98-4f19-ae16-bcd483fb3b3f

Job	Result	VERIFIED	Link
VariableDebtToken.conf	✅	15	Link
UserConfiguration.conf	✅	13	Link
stableRemoved.conf	✅	2	Link
RwaAToken.conf	✅	13	Link
ReserveConfiguration.conf	✅	19	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnReserveDisabledForBorrowing	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnFrozenReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawFromInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInFrozenReserve	✅	1	Link
NEW-pool-no-summarizations.conf	✅	3	Link
EModeConfiguration.conf	✅	5	Link
AToken.conf	✅	13	Link

github-actions · 2025-09-10T01:13:18Z

Download Logs

certora-run

Verification Results

Group ID: 12473792-c806-4bf0-851a-5ef4f39f1f07

Job	Result	VERIFIED	Link
VariableDebtToken.conf	✅	15	Link
UserConfiguration.conf	✅	13	Link
stableRemoved.conf	✅	2	Link
RwaAToken.conf	✅	13	Link
ReserveConfiguration.conf	✅	19	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnReserveDisabledForBorrowing	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnFrozenReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawFromInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInFrozenReserve	✅	1	Link
NEW-pool-no-summarizations.conf	✅	3	Link
EModeConfiguration.conf	✅	5	Link
AToken.conf	✅	13	Link

certora-run

Verification Results

Group ID: 12473792-c806-4bf0-851a-5ef4f39f1f07

Job	Result	VERIFIED	Link
VariableDebtToken.conf	⌛	0	Link
UserConfiguration.conf	✅	13	Link
stableRemoved.conf	⌛	0	Link
RwaAToken.conf	⌛	0	Link
ReserveConfiguration.conf	⌛	19	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowZeroAmount	⌛	0	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnReserveDisabledForBorrowing	⌛	0	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnInactiveReserve	⌛	0	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnFrozenReserve	⌛	0	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawZeroAmount	⌛	0	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawFromInactiveReserve	⌛	0	Link
NEW-pool-simple-properties.conf --rule cannotDepositZeroAmount	⌛	0	Link
NEW-pool-simple-properties.conf --rule cannotDepositInInactiveReserve	⌛	0	Link
NEW-pool-simple-properties.conf --rule cannotDepositInFrozenReserve	⌛	0	Link
NEW-pool-no-summarizations.conf	⌛	0	Link
EModeConfiguration.conf	✅	5	Link
AToken.conf	⌛	0	Link

certora-run

Verification Results

Group ID: ef788179-7398-4e36-8f43-e310b11dcb39

Job	Result	VERIFIED	Link
VariableDebtToken.conf	✅	15	Link
UserConfiguration.conf	✅	13	Link
stableRemoved.conf	✅	2	Link
RwaAToken.conf	✅	13	Link
ReserveConfiguration.conf	✅	19	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnReserveDisabledForBorrowing	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnFrozenReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawFromInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInFrozenReserve	✅	1	Link
NEW-pool-no-summarizations.conf	✅	3	Link
EModeConfiguration.conf	✅	5	Link
AToken.conf	✅	13	Link

certora-run

Verification Results

Group ID: e457faa8-f917-495c-8778-d37b5d45dbdb

Job	Result	VERIFIED	Link
VariableDebtToken.conf	✅	15	Link
UserConfiguration.conf	✅	13	Link
stableRemoved.conf	✅	2	Link
RwaAToken.conf	✅	13	Link
ReserveConfiguration.conf	✅	19	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnReserveDisabledForBorrowing	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule_sanity none --rule cannotBorrowOnFrozenReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotWithdrawFromInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositZeroAmount	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInInactiveReserve	✅	1	Link
NEW-pool-simple-properties.conf --rule cannotDepositInFrozenReserve	✅	1	Link
NEW-pool-no-summarizations.conf	✅	3	Link
EModeConfiguration.conf	✅	5	Link
AToken.conf	✅	13	Link

certora-run

Verification Results

Group ID: a2e142e6-d668-4695-88e3-a67f52ab8c0b

Job	Result	VERIFIED	Link
verifyStataToken.conf --rule totalClaimableRewards_stable	✅	2	Link
verifyStataToken.conf --rule totalAssets_stable	✅	2	Link
verifyStataToken.conf --rule solvency_total_asset_geq_total_supply	✅	2	Link
verifyStataToken.conf --rule solvency_positive_total_supply_only_if_positive_asset	✅	2	Link
verifyStataToken.conf --rule singleAssetAccruedRewards	✅	2	Link
verifyStataToken.conf --rule rewardsTotalDeclinesOnlyByClaim	✅	2	Link
verifyStataToken.conf --rule rewardsConsistencyWhenSufficientRewardsExist	✅	2	Link
verifyStataToken.conf --rule rewardsConsistencyWhenInsufficientRewards	✅	2	Link
verifyStataToken.conf --rule getClaimableRewards_stable	✅	2	Link
verifyStataToken.conf --rule getClaimableRewards_stable_after_refreshRewardTokens	✅	2	Link
verifyStataToken.conf --rule getClaimableRewards_stable_after_deposit	✅	2	Link
verifyStataToken.conf --rule getClaimableRewardsBefore_leq_claimed_claimRewardsOnBehalf	✅	2	Link
verifyERC4626Extended.conf --rule redeemSum	✅	2	Link
verifyERC4626Extended.conf --rule redeemATokensSum	✅	2	Link
verifyERC4626DepositSummarization.conf --rule depositCheckIndexGRayAssert1 depositATokensCheckIndexGRayAssert1 depositWithPermitCheckIndexGRayAssert1 depositCheckIndexERayAssert1 depositATokensCheckIndexERayAssert1 depositWithPermitCheckIndexERayAssert1	✅	7	Link
verifyERC4626.conf --rule maxMintMustntRevert maxDepositMustntRevert maxRedeemMustntRevert maxWithdrawMustntRevert totalAssetsMustntRevert	✅	6	Link
verifyDoubleClaim.conf --rule prevent_duplicate_reward_claiming_single_reward_sufficient	✅	2	Link
verifyDoubleClaim.conf --rule prevent_duplicate_reward_claiming_single_reward_insufficient	✅	2	Link
verifyAToken.conf --rule aTokenBalanceIsFixed_for_collectAndUpdateRewards aTokenBalanceIsFixed_for_claimRewards aTokenBalanceIsFixed_for_claimRewardsOnBehalf	✅	4	Link
verifyAToken.conf --rule aTokenBalanceIsFixed_for_claimSingleRewardOnBehalf aTokenBalanceIsFixed_for_claimRewardsToSelf	✅	3	Link
tWithPermitCheckIndexGRayAssert2 depositCheckIndexERayAssert2 depositATokensCheckIndexERayAssert2 depositWithPermitCheckIndexERayAssert2 mintCheckIndexGRayUpperBound mintCheckIndexGRayLowerBound mintCheckIndexEqualsRay	✅	10	Link
ToAssetsCheck convertToSharesCheck toAssetsDoesNotRevert sharesConversionRoundedDown toSharesDoesNotRevert previewDepositAmountCheck maxRedeemCompliance maxWithdrawConversionCompliance previewMintIndependentOfAllowance	✅	23	Link
ingRange previewRedeemRoundingRange amountConversionPreserved sharesConversionPreserved accountsJoiningSplittingIsLimited convertSumOfAssetsPreserved previewDepositSameAsDeposit previewMintSameAsMint maxDepositConstant	✅	10	Link

avniculae · 2025-09-22T20:55:08Z

scripts/misc/DeployLiquidationDataProvider.sol

+import {Script} from 'forge-std/Script.sol';
+
+contract DeployLiquidationDataProvider is Script {
+  address public constant POOL = 0xAe05Cd22df81871bc7cC2a04BeCfb516bFe332C8;


Ideally we should take these as inputs (maybe as args in run()), wdyt?

yes that would be more versatile, i did it like this bc I was focused on horizon deployment but good call

edit: bc5c38e

avniculae · 2025-09-22T20:55:56Z

Makefile

+deploy-liquidation-data-provider :;
+	FOUNDRY_PROFILE=${CHAIN} forge script scripts/misc/DeployLiquidationDataProvider.sol:DeployLiquidationDataProvider \
+		--rpc-url ${CHAIN} --account ${ACCOUNT} --slow --gas-estimate-multiplier 150 \
+		--chain ${CHAIN} --verifier etherscan \


I'd remove --verifier from here tbh, maybe add verifier-url? (to be able to use tenderly verifier is needed)

feat: liquidation data provider deployment script

89120ea

certora-run bot reviewed Sep 4, 2025

View reviewed changes

fix: CI

edef5b1

certora-run bot reviewed Sep 10, 2025

View reviewed changes

nisnislevi and others added 3 commits September 22, 2025 11:59

fix: Certora CI (#33)

4a76385

Merge branch 'main' into feat/liqDataProvider-script

d06de2a

chore: lint

4f5b164

certora-run bot reviewed Sep 22, 2025

View reviewed changes

chore: lint

6dd1023

certora-run bot reviewed Sep 22, 2025

View reviewed changes

yan-man marked this pull request as ready for review September 22, 2025 18:02

yan-man requested review from CanonicalJP, CheyenneAtapour, DhairyaSethi, The-3D, avniculae and miguelmtzinf as code owners September 22, 2025 18:02

miguelmtzinf approved these changes Sep 22, 2025

View reviewed changes

avniculae reviewed Sep 22, 2025

View reviewed changes

avniculae approved these changes Sep 22, 2025

View reviewed changes

test: clean up makefile; add fork test; pr comments

bc5c38e

This comment was marked as off-topic.

Sign in to view

yan-man merged commit dfcc124 into main Sep 22, 2025
10 checks passed

yan-man deleted the feat/liqDataProvider-script branch September 22, 2025 21:38

feat: liquidation data provider deployment script #32

feat: liquidation data provider deployment script #32

Uh oh!

Conversation

yan-man commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

certora-run bot left a comment

Choose a reason for hiding this comment

Verification Results

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

avniculae Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

yan-man Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avniculae Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

yan-man Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yan-man commented Sep 4, 2025 •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

yan-man Sep 22, 2025 •

edited

Loading