This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Add price validation to UiPoolDataProviderV3 #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement MAX_REASONABLE_PRICE constant (1e15) for bounds checking - Add validation after oracle price fetches to prevent extreme values - Handle zero/invalid oracle addresses gracefully - Return zero price for extreme values instead of propagating errors Fixes GitHub Issue #989 where UiPoolDataProvider returned extreme prices like 1.539e+35 on Arbitrum Sepolia due to oracle configuration issues. With this validation, prices are bounded to reasonable ranges while the underlying oracle issues are resolved in the deployment configs. Part of coordinated fix across aave-v3-deploy, aave-address-book, and aave-v3-periphery repositories.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GitHub Issue #989 where UiPoolDataProvider returned extreme prices like 1.539e+35 on Arbitrum Sepolia due to oracle configuration issues.
With this validation, prices are bounded to reasonable ranges while the underlying oracle issues are resolved in the deployment configs.
Part of coordinated fix across aave-v3-deploy, aave-address-book, and aave-v3-periphery repositories.
Related PRs:
#196
aave/aave-v3-deploy#77