aave
diff --git a/‎src/contracts/Hub.sol‎
Lines changed: 0 additions & 1 deletion b/‎src/contracts/Hub.sol‎
Lines changed: 0 additions & 1 deletion
diff --git a/‎src/contracts/Spoke.sol‎
Lines changed: 0 additions & 8 deletions b/‎src/contracts/Spoke.sol‎
Lines changed: 0 additions & 8 deletions
diff --git a/‎src/libraries/helpers/KeyValueListInMemory.sol‎
Lines changed: 0 additions & 2 deletions b/‎src/libraries/helpers/KeyValueListInMemory.sol‎
Lines changed: 0 additions & 2 deletions
diff --git a/‎src/libraries/logic/AssetLogic.sol‎
Lines changed: 0 additions & 2 deletions b/‎src/libraries/logic/AssetLogic.sol‎
Lines changed: 0 additions & 2 deletions
diff --git a/‎tests/Base.t.sol‎
Lines changed: 16 additions & 0 deletions b/‎tests/Base.t.sol‎
Lines changed: 16 additions & 0 deletions
diff --git a/‎tests/unit/HealthFactor.t.sol‎
Lines changed: 0 additions & 172 deletions b/‎tests/unit/HealthFactor.t.sol‎
Lines changed: 0 additions & 172 deletions
@@ -610,7 +610,6 @@ contract Hub is IHub, AccessManaged {
     spoke.realizedPremium = spoke.realizedPremium.add(premium.realizedDelta).toUint128();
 
     // can increase due to precision loss on premium (drawn unchanged)
-    // todo mathematically find premium diff ceiling and replace the `2`
     require(asset.premium() + premiumAmount - premiumBefore <= 2, InvalidPremiumChange());
   }
 
 
@@ -58,7 +58,6 @@ contract Spoke is ISpoke, Multicall, AccessManaged {
    * @param authority_ The address of the authority contract which manages permissions.
    */
   constructor(address authority_) AccessManaged(authority_) {
-    // todo move to `initialize` when adding upgradeability
     _liquidationConfig.closeFactor = Constants.HEALTH_FACTOR_LIQUIDATION_THRESHOLD;
     emit LiquidationConfigUpdate(_liquidationConfig);
   }
@@ -130,7 +129,6 @@ contract Spoke is ISpoke, Multicall, AccessManaged {
     uint256 reserveId,
     DataTypes.ReserveConfig calldata config
   ) external restricted {
-    // TODO: More sophisticated
     require(reserveId < _reserveCount, ReserveNotListed());
     DataTypes.Reserve storage reserve = _reserves[reserveId];
     _validateReserveConfig(config);
@@ -506,7 +504,6 @@ contract Spoke is ISpoke, Multicall, AccessManaged {
       uint256 totalDebtInBaseCurrency
     )
   {
-    // todo separate getter with refreshed config for users trying to incrementally build hf?
     (
       userRiskPremium,
       avgCollateralFactor,
@@ -582,12 +579,9 @@ contract Spoke is ISpoke, Multicall, AccessManaged {
     // HF checked at the end of borrow action
   }
 
-  // TODO: Place this and LH equivalent in a generic logic library
   function _validateRepay(DataTypes.Reserve storage reserve) internal view {
     require(address(reserve.hub) != address(0), ReserveNotListed());
     require(!reserve.paused, ReservePaused());
-    // todo validate user not trying to repay more
-    // todo NoExplicitAmountToRepayOnBehalf
   }
 
   /**
@@ -890,7 +884,6 @@ contract Spoke is ISpoke, Multicall, AccessManaged {
     );
   }
 
-  // todo optimize, merge logic duped borrow/repay, rename
   /**
    * @dev Trigger risk premium update on all drawn reserves of `user`.
    * @param user The address of the user whose risk premium is being updated.
@@ -905,7 +898,6 @@ contract Spoke is ISpoke, Multicall, AccessManaged {
     vars.reserveCount = _reserveCount;
     DataTypes.PositionStatus storage positionStatus = _positionStatus[user];
     while (vars.reserveId < vars.reserveCount) {
-      // todo keep borrowed assets in transient storage/pass through?
       if (positionStatus.isBorrowing(vars.reserveId)) {
         DataTypes.UserPosition storage userPosition = _userPositions[user][vars.reserveId];
         DataTypes.Reserve storage reserve = _reserves[vars.reserveId];
 
@@ -3,7 +3,6 @@ pragma solidity ^0.8.0;
 
 import {Arrays} from 'src/dependencies/openzeppelin/Arrays.sol';
 
-// todo: optimize by packing more elements each slot, keep pre-sorted
 library KeyValueListInMemory {
   error MaxKeySizeExceeded(uint256);
   error MaxValueSizeExceeded(uint256);
@@ -43,7 +42,6 @@ library KeyValueListInMemory {
 
   function sortByKey(List memory self) internal pure {
     // @dev since `key` is in the MSB, we can sort by the key by sorting the array
-    // todo consider using Solady's quick sort implementation, it being more gas efficient (cannot use if we pack more than 1 pair per slot)
     Arrays.sort(self._inner, ltComparator);
   }
 
 
@@ -18,8 +18,6 @@ library AssetLogic {
   using MathUtils for uint256;
   using SafeCast for uint256;
 
-  // todo: option for cached object
-
   // drawn exchange rate does not include premium to accrue base rate separately
   function toDrawnAssetsUp(
     DataTypes.Asset storage asset,
 
@@ -170,6 +170,13 @@ abstract contract Base is Test {
     uint256 premium;
   }
 
+  // TODO: Seems this should be replaced with DrawnAccounting struct
+  struct Debts {
+    uint256 drawnDebt;
+    uint256 premiumDebt;
+    uint256 totalDebt;
+  }
+
   struct AssetPosition {
     uint256 assetId;
     uint256 addedShares;
@@ -1177,6 +1184,15 @@ abstract contract Base is Test {
     return spoke.getUserPosition(reserveId, user);
   }
 
+  function getUserDebt(
+    ISpoke spoke,
+    address user,
+    uint256 reserveId
+  ) internal view returns (Debts memory data) {
+    (data.drawnDebt, data.premiumDebt) = spoke.getUserDebt(reserveId, user);
+    data.totalDebt = data.drawnDebt + data.premiumDebt;
+  }
+
   function getReserveInfo(
     ISpoke spoke,
     uint256 reserveId
Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,6 @@ contract Hub is IHub, AccessManaged {`
`610`	`610`	`spoke.realizedPremium = spoke.realizedPremium.add(premium.realizedDelta).toUint128();`
`611`	`611`
`612`	`612`	`// can increase due to precision loss on premium (drawn unchanged)`
`613`		- // todo mathematically find premium diff ceiling and replace the `2`
`614`	`613`	`require(asset.premium() + premiumAmount - premiumBefore <= 2, InvalidPremiumChange());`
`615`	`614`	`}`
`616`	`615`