fix : address pr comments

Kogaroshi · Kogaroshi · commit 59d387583ac8 · 2025-12-15T15:28:16.000+01:00
diff --git a/src/access/AccessManagerEnumerable.sol b/src/access/AccessManagerEnumerable.sol
@@ -136,7 +136,7 @@ contract AccessManagerEnumerable is AccessManager, IAccessManagerEnumerable {
     if (oldRole != ADMIN_ROLE && _roleTargetFunctions[uint64(oldRole)][target].length() == 0) {
       _roleTargets[uint64(oldRole)].remove(target);
     }
-    if (roleId != ADMIN_ROLE && !_roleTargets[roleId].contains(target)) {
+    if (roleId != ADMIN_ROLE) {
       _roleTargets[roleId].add(target);
     }
     _targetRoles[target] = roleId;

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ contract AccessManagerEnumerable is AccessManager, IAccessManagerEnumerable {`
`136`	`136`	`if (oldRole != ADMIN_ROLE && _roleTargetFunctions[uint64(oldRole)][target].length() == 0) {`
`137`	`137`	`_roleTargets[uint64(oldRole)].remove(target);`
`138`	`138`	`}`
`139`		`- if (roleId != ADMIN_ROLE && !_roleTargets[roleId].contains(target)) {`
	`139`	`+ if (roleId != ADMIN_ROLE) {`
`140`	`140`	`_roleTargets[roleId].add(target);`
`141`	`141`	`}`
`142`	`142`	`_targetRoles[target] = roleId;`