feat: remove permissionless updateUserRiskPremium logic (#722)

Author: DhairyaSethi

snapshots/Spoke.Operations.json

@@ -1,13 +1,13 @@
 {
-  "borrow: first": "248096",
-  "borrow: second action, same reserve": "211568",
-  "liquidationCall: full": "316501",
-  "liquidationCall: partial": "340172",
-  "permitReserve + repay (multicall)": "268517",
-  "permitReserve + supply (multicall)": "140632",
-  "permitReserve + supply + enable collateral (multicall)": "174117",
-  "repay: full": "172778",
-  "repay: partial": "227277",
+  "borrow: first": "248044",
+  "borrow: second action, same reserve": "211516",
+  "liquidationCall: full": "316449",
+  "liquidationCall: partial": "340120",
+  "permitReserve + repay (multicall)": "268464",
+  "permitReserve + supply (multicall)": "140631",
+  "permitReserve + supply + enable collateral (multicall)": "174116",
+  "repay: full": "172756",
+  "repay: partial": "227225",
   "setUserPositionManagerWithSig: disable": "42808",
   "setUserPositionManagerWithSig: enable": "66831",
   "supply + enable collateral (multicall)": "152550",
@@ -17,12 +17,12 @@
   "supply: second action, same reserve": "102491",
   "updateUserDynamicConfig: 1 collateral": "53152",
   "updateUserDynamicConfig: 2 collaterals": "58433",
-  "updateUserRiskPremium: 1 borrow": "121368",
-  "updateUserRiskPremium: 2 borrows": "157278",
+  "updateUserRiskPremium: 1 borrow": "121382",
+  "updateUserRiskPremium: 2 borrows": "157262",
   "usingAsCollateral: 0 borrows, enable": "54026",
-  "usingAsCollateral: 1 borrow, disable": "131660",
+  "usingAsCollateral: 1 borrow, disable": "131608",
   "usingAsCollateral: 1 borrow, enable": "24786",
-  "withdraw: 0 borrows, full": "135190",
-  "withdraw: 0 borrows, partial": "137293",
-  "withdraw: 1 borrow, partial": "238008"
+  "withdraw: 0 borrows, full": "135168",
+  "withdraw: 0 borrows, partial": "137271",
+  "withdraw: 1 borrow, partial": "237956"
 }

src/contracts/Spoke.sol

@@ -394,13 +394,10 @@ contract Spoke is ISpoke, Multicall, AccessManaged, EIP712 {
 
   /// @inheritdoc ISpoke
   function updateUserRiskPremium(address onBehalfOf) external {
-    DataTypes.UserAccountData memory userAccountData = _calculateUserAccountData(onBehalfOf);
-    bool premiumIncrease = _notifyRiskPremiumUpdate(onBehalfOf, userAccountData.userRiskPremium);
-
-    // check permissions if premium increases and not called by user
-    if (premiumIncrease && !_isPositionManager({user: onBehalfOf, manager: msg.sender})) {
+    if (!_isPositionManager({user: onBehalfOf, manager: msg.sender})) {
       _checkCanCall(msg.sender, msg.data);
     }
+    _notifyRiskPremiumUpdate(onBehalfOf, _calculateUserAccountData(onBehalfOf).userRiskPremium);
   }
 
   /// @inheritdoc ISpoke
@@ -916,17 +913,12 @@ contract Spoke is ISpoke, Multicall, AccessManaged, EIP712 {
    * @dev Trigger risk premium update on all drawn reserves of `user`.
    * @param user The address of the user whose risk premium is being updated.
    * @param newUserRiskPremium The new risk premium of the user.
-   * @return premiumIncrease True if the risk premium increased, false otherwise.
    */
-  function _notifyRiskPremiumUpdate(
-    address user,
-    uint256 newUserRiskPremium
-  ) internal returns (bool) {
+  function _notifyRiskPremiumUpdate(address user, uint256 newUserRiskPremium) internal {
     uint256 reserveCount = _reserveCount;
     DataTypes.PositionStatus storage positionStatus = _positionStatus[user];
 
     uint256 reserveId;
-    bool premiumIncrease;
     while (
       (reserveId = positionStatus.nextBorrowing(reserveId, reserveCount)) !=
       PositionStatus.NOT_FOUND
@@ -957,15 +949,11 @@ contract Spoke is ISpoke, Multicall, AccessManaged, EIP712 {
         realizedDelta: accruedUserPremium.toInt256()
       });
 
-      if (!premiumIncrease) premiumIncrease = premiumDelta.sharesDelta > 0;
-
       hub.refreshPremium(assetId, premiumDelta);
       emit RefreshPremiumDebt(reserveId, user, premiumDelta);
       reserveId = reserveId.uncheckedAdd(1);
     }
     emit UserRiskPremiumUpdate(user, newUserRiskPremium);
-
-    return premiumIncrease;
   }
 
   /**

src/interfaces/ISpoke.sol

@@ -193,15 +193,14 @@ interface ISpoke is ISpokeBase, IMulticall, IAccessManaged {
   ) external;
 
   /**
-   * @notice Allows updating the risk premium on user position.
-   * @dev If the risk premium has increased, the caller must be `user`, an authorized position manager
-   * of `user`, or admin.
-   * @param user The address of the user.
+   * @notice Allows updating the risk premium on onBehalfOf position.
+   * @dev Caller must be `onBehalfOf`, an authorized position manager for `onBehalfOf`, or admin.
+   * @param onBehalfOf The owner of the position being modified.
    */
-  function updateUserRiskPremium(address user) external;
+  function updateUserRiskPremium(address onBehalfOf) external;
 
   /**
-   * @notice Allows updating the dynamic configuration for all collateral reserves of a user position.
+   * @notice Allows updating the dynamic configuration for all collateral reserves on onBehalfOf position.
    * @dev Caller must be `onBehalfOf`, an authorized position manager for `onBehalfOf`, or admin.
    * @param onBehalfOf The owner of the position being modified.
    */