Skip to content

Constants do not follow naming convention #1048

@miguelmtzinf

Description

@miguelmtzinf
  • Remove the underscore preffix in KeyValueList constants
    uint256 internal constant _KEY_BITS = 32;
    uint256 internal constant _VALUE_BITS = 224;
    uint256 internal constant _MAX_KEY = (1 << _KEY_BITS) - 1;
    uint256 internal constant _MAX_VALUE = (1 << _VALUE_BITS) - 1;
    uint256 internal constant _KEY_SHIFT = 256 - _KEY_BITS;
  • _nativeWrapper can be made public instead, name in uppercase.
    INativeWrapper internal immutable _nativeWrapper;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions