Skip to content

Conversation

@matchv
Copy link
Collaborator

@matchv matchv commented Jul 24, 2025

  • Change withdraw function from public fun to public entry fun
  • Allows funds admin to directly call the function via wallet/CLI
  • Maintains existing permission checks and functionality
  • Addresses security concern about admin accessibility

- Change withdraw function from public fun to public entry fun
- Allows funds admin to directly call the function via wallet/CLI
- Maintains existing permission checks and functionality
- Addresses security concern about admin accessibility
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (566c23b) to head (0a9c347).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          16       16           
  Lines         514      514           
=======================================
  Hits          499      499           
  Misses         15       15           
Flag Coverage Δ
move 97.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@mpsc0x mpsc0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matchv Approved, but could you link to the issue tackled in here. In general its better to have in exposed as it would otherwise only allow scripts to call it.

@mpsc0x mpsc0x merged commit be2f7c1 into main Jul 24, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants