fix(transfer_strategy): change emergency withdrawal to entry function #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matchv
commented
Jul 24, 2025
matchv
commented
- Change pull_rewards_transfer_strategy_emergency_withdrawal from public fun to public entry fun
- Allows admin accounts to directly call emergency withdrawal via wallet/CLI
- Maintains existing permission checks (only rewards admin can call)
- Change pull_rewards_transfer_strategy_emergency_withdrawal from public fun to public entry fun - Allows admin accounts to directly call emergency withdrawal via wallet/CLI - Maintains existing permission checks (only rewards admin can call) - Fixes audit issue #111: Admin cannot perform pull_rewards_transfer_strategy_emergency_withdrawal Security Impact: - Improves admin accessibility for emergency operations - No change to function logic or permission validation - Preserves all existing security measures
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 16 16
Lines 514 514
=======================================
Hits 499 499
Misses 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meng-xu-cs
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.