Skip to content

fix(reserve_config): standardize MAX_VALID_DECIMALS to 18 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix(reserve_config): standardize MAX_VALID_DECIMALS to 18 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aave-core/aave-config/sources/reserve_config.move
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module aave_config::reserve_config {
const MAX_VALID_LTV: u256 = 65535;
const MAX_VALID_LIQUIDATION_THRESHOLD: u256 = 65535;
const MAX_VALID_LIQUIDATION_BONUS: u256 = 65535;
const MAX_VALID_DECIMALS: u256 = 255;
const MAX_VALID_DECIMALS: u256 = 18;
const MAX_VALID_RESERVE_FACTOR: u256 = 65535;
const MAX_VALID_BORROW_CAP: u256 = 68719476735;
const MAX_VALID_SUPPLY_CAP: u256 = 68719476735;
Expand Down
2 changes: 1 addition & 1 deletion aave-core/aave-config/tests/reserve_config_tests.move
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ module aave_config::reserve_tests {
let reserve_config = init();
assert!(get_emode_category(&reserve_config) == ZERO, SUCCESS);

set_emode_category(&mut reserve_config, get_max_valid_decimals() + 1);
set_emode_category(&mut reserve_config, get_max_valid_emode_category() + 1);
assert!(get_emode_category(&reserve_config) == ZERO, SUCCESS);
}

Expand Down
4 changes: 2 additions & 2 deletions aave-core/tests/aave-pool/pool_tests.move
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ module aave_pool::pool_tests {
reserve_config::set_ltv(&mut reserve_config_new, 100);
reserve_config::set_liquidation_threshold(&mut reserve_config_new, 101);
reserve_config::set_liquidation_bonus(&mut reserve_config_new, 102);
reserve_config::set_decimals(&mut reserve_config_new, 103);
reserve_config::set_decimals(&mut reserve_config_new, 18);
reserve_config::set_active(&mut reserve_config_new, true);
reserve_config::set_frozen(&mut reserve_config_new, true);
reserve_config::set_paused(&mut reserve_config_new, true);
Expand Down Expand Up @@ -547,7 +547,7 @@ module aave_pool::pool_tests {
reserve_config::get_liquidation_bonus(&reserve_config_map) == 102,
TEST_SUCCESS
);
assert!(reserve_config::get_decimals(&reserve_config_map) == 103, TEST_SUCCESS);
assert!(reserve_config::get_decimals(&reserve_config_map) == 18, TEST_SUCCESS);
assert!(reserve_config::get_active(&reserve_config_map) == true, TEST_SUCCESS);
assert!(reserve_config::get_frozen(&reserve_config_map) == true, TEST_SUCCESS);
assert!(reserve_config::get_paused(&reserve_config_map) == true, TEST_SUCCESS);
Expand Down
Loading