Skip to content

Conversation

@matchv
Copy link
Collaborator

@matchv matchv commented Jul 29, 2025

  • Add transfer logic of underlying token balance when drop_reserve()
  • Implement proper treasury transfer mechanism for remaining underlying assets before reserve removal
  • Add comprehensive test coverage to verify drop_reserve behavior across different time periods
  • Validate treasury balance transfer and resource account cleanup in drop_reserve operations
  • Improve test assertions to verify asset accounting accuracy

Test scenarios covered:

  • 6 months, 1 year, 2 years, and 5 years interest accrual periods
  • Verification of accrued_to_treasury and underlying balance
  • Treasury balance transfer validation after drop_reserve execution

- Add comprehensive asset transfer logic to prevent locking when drop_reserve called with remaining underlying assets
- Implement proper treasury transfer mechanism for remaining underlying assets before reserve removal
- Add comprehensive test coverage to verify drop_reserve behavior across different time periods
- Validate treasury balance transfer and resource account cleanup in drop_reserve operations
- Improve test assertions to verify asset accounting accuracy

Test scenarios covered:
- 6 months, 1 year, 2 years, and 5 years interest accrual periods
- Verification of accrued_to_treasury and underlying balance relationships
- Treasury balance transfer validation after drop_reserve execution
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.89%. Comparing base (6356330) to head (1604c74).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   97.08%   96.89%   -0.19%     
==========================================
  Files          16       16              
  Lines         514      515       +1     
==========================================
  Hits          499      499              
- Misses         15       16       +1     
Flag Coverage Δ
move 96.89% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mpsc0x
mpsc0x previously approved these changes Jul 30, 2025
meng-xu-cs
meng-xu-cs previously approved these changes Jul 31, 2025
- Update @eslint/plugin-kit from <0.3.4 to >=0.3.4 to fix Regular Expression Denial of Service vulnerability
- Add security override in pnpm-workspace.yaml to enforce minimum secure version
- Update pnpm-lock.yaml with patched dependency versions
- Fix GitHub CI pipeline failure caused by security audit

Security fix:
- Addresses GHSA-xffm-g5w8-qvg7 vulnerability in ConfigCommentParser
- Prevents potential ReDoS attacks through malicious regex patterns
- Ensures development environment security compliance

Files modified:
- pnpm-workspace.yaml: Add security override for @eslint/plugin-kit
- pnpm-lock.yaml: Update dependency lock file with secure versions

This fix resolves the CI pipeline failure and ensures all dependencies meet security requirements.
@matchv matchv dismissed stale reviews from meng-xu-cs and mpsc0x via 1604c74 July 31, 2025 14:51
@mpsc0x mpsc0x merged commit 77188e2 into main Jul 31, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants