feat(validation_logic): disable auto set asset as collateral #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eralization - Enhance protocol security and user experience by requiring explicit collateral activation - Users must now manually call set_user_use_reserve_as_collateral to enable collateral - Eliminate potential state inconsistencies and improve protocol predictability - Update all related test cases to reflect new manual collateral activation behavior - Provide users with full control over their collateral settings This improvement: - Reduces protocol complexity and potential edge cases - Improves user control and account state management - Enhances protocol reliability and safety - Slightly increases user operation steps but greatly improves protocol predictability Files modified: - sources/aave-logic/validation_logic.move: Core logic improvement - tests/aave-logic/*.move: Test case adaptations for new behavior - tests/aave-pool/*.move: Pool-related test updates - tests/aave-periphery/*.move: Periphery test updates Breaking change: Users must now explicitly enable collateral after supply/transfer/liquidation operations
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 97.08% 96.89% -0.19%
==========================================
Files 16 16
Lines 514 515 +1
==========================================
Hits 499 499
- Misses 15 16 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpsc0x
previously approved these changes
Jul 30, 2025
Collaborator
|
@matchv Please fix the typescript int. test too +rebase to get rid of hte npm failed audits. |
meng-xu-cs
previously approved these changes
Jul 31, 2025
mpsc0x
force-pushed
the
mike/improve/150-285
branch
from
3e5e8a6 to
7df7baa
Compare
…eral activation - Update all TypeScript integration tests to manually call setUserUseReserveAsCollateral - Ensure proper collateral setup before borrow, liquidation, and withdraw operations - Fix test failures caused by disabled auto-collateralization feature - Maintain test coverage while adapting to new security improvements Test files updated: - borrow.spec.ts: Add manual collateral activation before borrow operations - liquidation.spec.ts: Ensure collateral is properly set for liquidation scenarios - liquidation-underlying.spec.ts: Fix underlying asset liquidation tests - withdraw.spec.ts: Add collateral setup for withdrawal operations - repay.spec.ts: Update repayment test collateral handling - repay-atoken.spec.ts: Fix aToken repayment test collateral setup
- Update @eslint/plugin-kit from <0.3.4 to >=0.3.4 to fix Regular Expression Denial of Service vulnerability - Add security override in pnpm-workspace.yaml to enforce minimum secure version - Update pnpm-lock.yaml with patched dependency versions - Fix GitHub CI pipeline failure caused by security audit Security fix: - Addresses GHSA-xffm-g5w8-qvg7 vulnerability in ConfigCommentParser - Prevents potential ReDoS attacks through malicious regex patterns - Ensures development environment security compliance Files modified: - pnpm-workspace.yaml: Add security override for @eslint/plugin-kit - pnpm-lock.yaml: Update dependency lock file with secure versions This fix resolves the CI pipeline failure and ensures all dependencies meet security requirements.
matchv
force-pushed
the
mike/improve/150-285
branch
from
a802487 to
f4b4285
Compare
mpsc0x
approved these changes
Jul 31, 2025
meng-xu-cs
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to mitigate griefing and/or DOS attacks.
Files modified:
Breaking change: Users must now explicitly enable collateral after supply/transfer/liquidation operations