fix: Added explicit dropping of TokenBaseState in drop method #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 16 16
Lines 515 515
=======================================
Hits 499 499
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meng-xu-cs
previously approved these changes
Aug 4, 2025
Comment on lines
657
to
661
| if (smart_table::length(&user_state) == 0) { | ||
| smart_table::destroy_empty(user_state); | ||
| } else { | ||
| smart_table::destroy(user_state); | ||
| }; |
Collaborator
There was a problem hiding this comment.
I think you can skip the if check and just use destroy
matchv
previously approved these changes
Aug 4, 2025
mpsc0x
force-pushed
the
fix/mpsc0x/dropping-token-base-state
branch
from
1f33499 to
b2befbc
Compare
meng-xu-cs
approved these changes
Aug 4, 2025
matchv
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly destructs the TokenBaseState and deallocates any storage when the token is dropped.