fix: assert custom asset price is less than the price cap #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oracle module allows either the asset listing admin or the pool admin to set a custom price for certain assets. However, the set_asset_custom_price function does not verify whether a price cap is defined for the asset. As a result, if a custom price is set above the cap, the oracle will still return the capped price rather than the custom price. This discrepancy can lead to unintended consequences, as the effective price used by the system will differ from the custom price that was set. The PR corrects this behaviour.