-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Added examples package with commands and flashloan examples #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a8d7d3 to
070f65c
Compare
070f65c to
96bf9ba
Compare
96bf9ba to
da0543e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage ? 97.09%
=======================================
Files ? 16
Lines ? 516
Branches ? 0
=======================================
Hits ? 501
Misses ? 15
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
da0543e to
d550e0d
Compare
meng-xu-cs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this Move script is purely demonstrative purpose and is not part of the Aave protocol, I wouldn't recommend putting it under the aave-core directory, nor have it linked up with the Makefile.
Instead, if possible, we can have an examples or tutorial directory and put the flashloan scripts as a Move package there, i.e.,
<git-repo-directory>/examples/flashloan where in this directory we have Move.toml which already hardcode the addresses of relevant Aave packages in the .toml file (instead of passing them via the Makefile).
Users should be able to invoke the Move scripts via aptos move run-script command under that examples/flashloan directory.
|
Agree with @meng-xu-cs that we better create a separate folder for this script. |
7ee3e1e to
dd63aab
Compare
dd63aab to
3fc8f4c
Compare
2f02c78 to
3250600
Compare
I followed your advice and have moved the package into examples now. There is a separate Makefile inside examples as the commands are quite complex and I wanted the users to be guided all the way. Also, I have decided not to hardcore the values as we can elegantly pass them through the Makefile command without polluting the example. I find it more elegant and it naturally follows the root Makefile idea and structure. I have also added a pipeline compile check for them and updated the README. cc @matchv @meng-xu-cs |
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
3250600 to
78fadd3
Compare
matchv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.