Mike/improve/generic logic #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matchv
commented
Oct 11, 2025
matchv
commented
- get_user_debt_in_base_currency: use ray_mul_up to round up debt
- get_user_debt_in_base_currency: use ceil_div to avoid smaller debt truncating to zero
- get_user_balance_in_base_currency: ray_mul_down to round down collateral balance
Apply directional rounding for conservative debt calculation. Changes: - Modified get_user_debt_in_base_currency function L37 - Changed ray_mul to ray_mul_up for debt index multiplication Rationale: - Debt should never be underestimated for protocol safety - Conservative calculation protects against liquidation edge cases - Aligns with Solidity Aave V3 implementation pattern Impact: - Health factor calculations become more conservative - Slight increase in debt amounts (~0.0001% per operation) - Better protection against dust debt scenarios
Apply ceiling division for conservative debt amount calculation. Changes: - Modified get_user_debt_in_base_currency function L42-45 - Changed regular division to ceil_div for price conversion - Simplified code by combining multiplication and division Rationale: - Prevents small debt × low price from rounding down to zero - Critical fix for test_issue_2 scenario - Ensures debt is always counted in base currency calculations Impact: - Fixes dust debt being ignored in health factor calculations - Small debt amounts will now be properly tracked - More accurate liquidation threshold determinations
Apply directional rounding for conservative collateral valuation. Changes: - Modified get_user_balance_in_base_currency function L62-70 - Changed ray_mul to ray_mul_down for collateral index multiplication Rationale: - Collateral should never be overestimated for protocol safety - Conservative calculation prevents over-leveraging - Consistent with a_token_factory::balance_of behavior Impact: - Health factor calculations become more conservative - Slight decrease in collateral value (~0.0001% per operation) - Better protection against liquidation edge cases
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mike/improve/pool-token-logic #68 +/- ##
==============================================================
Coverage 97.70% 97.70%
==============================================================
Files 38 38
Lines 785 785
==============================================================
Hits 767 767
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpsc0x
approved these changes
Oct 13, 2025
meng-xu-cs
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.