Skip to content

Mike/improve/generic logic #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Mike/improve/generic logic #68

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb111d7
feat(generic-logic): use ray_mul_up for debt scaled to actual conversion
matchv Oct 10, 2025
5fd1543
feat(generic-logic): use ceil_div for debt to base currency conversion
matchv Oct 10, 2025
32aa70b
feat(generic-logic): use ray_mul_down for collateral calculation
matchv Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions aave-core/sources/aave-logic/generic_logic.move
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,15 @@ module aave_pool::generic_logic {

if (user_total_debt != 0) {
let normalized_debt = pool::get_normalized_debt_by_reserve_data(reserve_data);
user_total_debt = wad_ray_math::ray_mul(user_total_debt, normalized_debt);
// Note: Use ray_mul_up for conservative debt calculation
// Ensures user debt is never underestimated in health factor calculations
user_total_debt = wad_ray_math::ray_mul_up(user_total_debt, normalized_debt);
};

user_total_debt = asset_price * user_total_debt;

user_total_debt / asset_unit
// Note: Use ceil_div for conservative debt conversion to base currency
// Prevents rounding down small debt amounts to zero
// Critical for accurate debt tracking in low-price or small-amount scenarios
math_utils::ceil_div(asset_price * user_total_debt, asset_unit)
}

/// @notice Calculates total aToken balance of the user in the based currency used by the price oracle
Expand All @@ -56,8 +59,10 @@ module aave_pool::generic_logic {
asset_unit: u256
): u256 {
let normalized_income = pool::get_normalized_income_by_reserve_data(reserve_data);
// Note: Use ray_mul_down for conservative collateral calculation
// Ensures user collateral is never overestimated in health factor calculations
let balance =
wad_ray_math::ray_mul(
wad_ray_math::ray_mul_down(
a_token_factory::scaled_balance_of(
user, pool::get_reserve_a_token_address(reserve_data)
),
Expand Down
Loading