feat(supply-logic): use ray_mul_down for withdraw balance calculation #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply directional rounding for conservative withdrawal balance calculation. Changes: - Calculate user_balance using ray_mul_down instead of ray_mul in withdraw function - Modified: supply_logic.move line 199-206 Rationale: - User withdrawal balance should never be overestimated for protocol safety - Conservative calculation prevents users from withdrawing more than actual balance - Consistent with a_token_factory::balance_of behavior - Aligns with Solidity Aave V3 implementation pattern Impact: - Withdrawal balance calculations become more conservative - User may need to query real-time balance for complete withdrawal - Better protection against over-withdrawal scenarios - Consistent with balance_of external API behavior
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mike/improve/generic-logic #70 +/- ##
===========================================================
Coverage 97.70% 97.70%
===========================================================
Files 38 38
Lines 785 785
===========================================================
Hits 767 767
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meng-xu-cs
approved these changes
Oct 14, 2025
mpsc0x
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withdraw: ray_mul => ray_mul_down to round down user's asset balance.