feat(liquidation-logic) #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion Apply directional rounding for conservative liquidation debt calculation. Changes: - Calculate user_reserve_debt_in_base_currency using ceil_div instead of normal division - Modified: execute_liquidation_call function (L627-640) - Keep collateral calculation with normal division (rounds down conservatively) Rationale: - Debt should never be underestimated during liquidation for protocol safety - Conservative calculation prevents liquidation amount errors - Ensures accurate liquidation bonus and collateral seizure calculations - Aligns with Solidity Aave V3 implementation pattern Impact: - Liquidation calculations become more conservative - Small debt amounts will not be rounded to zero (fixes potential dust debt issues) - Better protection against debt underestimation in liquidation scenarios - Consistent with generic_logic debt calculation approach
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mike/improve/supply-logic #71 +/- ##
==========================================================
Coverage 97.70% 97.70%
==========================================================
Files 38 38
Lines 785 785
==========================================================
Hits 767 767
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpsc0x
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute_liquidate_call, use math_utils::ceil_div() to count in dust debt
collateral accounting use regular div to round down collateral