Mike/improve/flashloan logic #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation Apply directional rounding for conservative flashloan liquidity calculation. Changes: - Calculate total_liquidity using ray_mul_down instead of ray_mul - Modified: handle_flash_loan_repayment function (L751-759) - Convert reserve_accrued_to_treasury to actual amount using conservative rounding Rationale: - Available flashloan liquidity should not be overestimated for protocol safety - Conservative calculation prevents lending more than actually available - Ensures treasury accrued balance doesn't inflate available liquidity - Aligns with mint_to_treasury's conservative approach Impact: - Flashloan availability becomes slightly more conservative (~0.0001%) - Prevents protocol from over-lending during high utilization - Better protection against liquidity miscalculation - Consistent with other directional rounding implementations
…rual Apply directional rounding for conservative flashloan treasury accumulation. Changes: - Calculate new_reserve_accrued_to_treasury using ray_div_down instead of ray_div - Modified: handle_flash_loan_repayment function (L767-776) - Convert premium_to_protocol from actual amount to scaled balance conservatively Rationale: - Protocol treasury should not accumulate optimistic amounts for safety - Conservative calculation prevents treasury from over-accruing fees - Ensures consistency with mint_to_treasury's conservative minting approach - Prevents long-term accumulation of rounding errors favoring treasury Impact: - Treasury accrual becomes slightly more conservative (~0.0001%) - Prevents protocol from recording more treasury fees than actually earned - Better alignment with dual-conservative approach (liquidity + treasury) - Consistent with other directional rounding implementations across protocol
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mike/improve/liquidation-logic #72 +/- ##
===============================================================
Coverage 97.70% 97.70%
===============================================================
Files 38 38
Lines 785 785
===============================================================
Hits 767 767
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpsc0x
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_flash_loan_repayment: total_supply => ray_mul_down, counting liquidity conservatively
handle_flash_loan_repayment: new_reserve_accrued_to_treasury => ray_mul_down, accrue treasury income conservatively