-
Notifications
You must be signed in to change notification settings - Fork 12
feat: added gho reserve configurator and script #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 38 38
Lines 786 786
=======================================
Hits 767 767
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| emode_category: option::some<u256>(1) // ok | ||
| } | ||
| ); | ||
| smart_table::upsert(// TODO: fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "TODO: fix it" mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong wording - means updating the values once we have them.
| smart_table::upsert( | ||
| &mut underlying_assets_testnet, | ||
| utf8(GHO_ASSET), | ||
| @0x0 // TODO: fix address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"TODO: fix address" - shall we feed a fix address here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by TODO I meant adding the gho address after we have it deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wil lchange it to a note or something, you are right, there is nothing to fix, rather update.
No description provided.