Mike/improve/transfer rounding #77
Merged
+50
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation - Add rounding_up: bool parameter to control rounding direction - Use ray_div_up when rounding_up=true, ray_div when rounding_up=false - Update liquidation collateral transfer to use rounding_up=true (favor protocol) - Update liquidation protocol fee transfer to use rounding_up=false (favor user) - Update function documentation and inline comments - Fix all affected unit tests to pass new parameter - Align with directional rounding principles and existing API patterns
- Add rounding_up: bool parameter to token_base::transfer - Update a_token_factory::transfer_on_liquidation to use rounding parameter - Update pool_token_logic::transfer to pass rounding_up=false for user transfers - Update liquidation calls to use appropriate rounding: - Collateral transfer: rounding_up=true (favor protocol, consistent with burn) - Protocol fee transfer: rounding_up=false (conservative charging) - Align with existing mint_scaled/burn_scaled API patterns - Ensure complete liquidation without dust accumulation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 38 38
Lines 786 786
=======================================
Hits 767 767
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpsc0x
approved these changes
Oct 29, 2025
meng-xu-cs
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add up/down param to the function and its call chain:
token_base::transfer
a_token_factory::transfer
pool_token_logic::transfer
finally
liquidation_logic, rounding up a_token transfer in "liquidation -> receive a_token" path, so the amount of a_token transferred match exactly the v_token burned, so the party being liquidated will not have 1 octa or any unit of a_token left in the account.
Note:
Without this PR, when the liquidating party choose to receive a_token, the party being liquidated may have 1 octa left in the collateral asset after a full liquidation, this is an un-exploitable dust, but still it is better to align the math of "receive a_token" path with the "burn debt token" path.