chore: add deployment static validations

DhairyaSethi · DhairyaSethi · commit b4c0cfe00ab3 · 2025-04-24T23:45:29.000+05:30
diff --git a/contracts/script/DeployUpgradableBurnMintTokenPool.s.sol b/contracts/script/DeployUpgradableBurnMintTokenPool.s.sol
@@ -47,7 +47,7 @@ contract DeployUpgradableBurnMintTokenPool is Script {
     console.log("tokenPoolProxy          ", tokenPoolProxy);
     console.log("tokenPoolImplementation ", tokenPool);
 
-    _validateProxyAdminVersion(tokenPoolProxy);
+    _validate(tokenPoolProxy, config);
   }
 
   function _parseConfig() internal view returns (Config memory) {
@@ -64,8 +64,12 @@ contract DeployUpgradableBurnMintTokenPool is Script {
     return config;
   }
 
-  function _validateProxyAdminVersion(address proxy) internal view {
+  function _validate(address proxy, Config memory config) internal view {
     require(_cmp(_getProxyAdmin(proxy).UPGRADE_INTERFACE_VERSION(), "5.0.0"), "InvalidProxyAdminVersion");
+    require(_getProxyAdmin(proxy).owner() == config.OWNER, "InvalidProxyAdminOwner");
+    require(address(UpgradeableBurnMintTokenPool(proxy).getToken()) == config.GHO_TOKEN, "InvalidToken");
+    require(UpgradeableBurnMintTokenPool(proxy).getRmnProxy() == config.RMN_PROXY, "InvalidRmnProxy");
+    require(UpgradeableBurnMintTokenPool(proxy).getRouter() == config.ROUTER, "InvalidRouter");
   }
 
   function _getProxyAdmin(address proxy) internal view returns (ProxyAdmin) {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ contract DeployUpgradableBurnMintTokenPool is Script {`
`47`	`47`	`console.log("tokenPoolProxy ", tokenPoolProxy);`
`48`	`48`	`console.log("tokenPoolImplementation ", tokenPool);`
`49`	`49`
`50`		`- _validateProxyAdminVersion(tokenPoolProxy);`
	`50`	`+ _validate(tokenPoolProxy, config);`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`function _parseConfig() internal view returns (Config memory) {`
`@@ -64,8 +64,12 @@ contract DeployUpgradableBurnMintTokenPool is Script {`
`64`	`64`	`return config;`
`65`	`65`	`}`
`66`	`66`
`67`		`- function _validateProxyAdminVersion(address proxy) internal view {`
	`67`	`+ function _validate(address proxy, Config memory config) internal view {`
`68`	`68`	`require(_cmp(_getProxyAdmin(proxy).UPGRADE_INTERFACE_VERSION(), "5.0.0"), "InvalidProxyAdminVersion");`
	`69`	`+ require(_getProxyAdmin(proxy).owner() == config.OWNER, "InvalidProxyAdminOwner");`
	`70`	`+ require(address(UpgradeableBurnMintTokenPool(proxy).getToken()) == config.GHO_TOKEN, "InvalidToken");`
	`71`	`+ require(UpgradeableBurnMintTokenPool(proxy).getRmnProxy() == config.RMN_PROXY, "InvalidRmnProxy");`
	`72`	`+ require(UpgradeableBurnMintTokenPool(proxy).getRouter() == config.ROUTER, "InvalidRouter");`
`69`	`73`	`}`
`70`	`74`
`71`	`75`	`function _getProxyAdmin(address proxy) internal view returns (ProxyAdmin) {`