Skip to content

Commit 16a5d59

Browse files
committed
feat: add todo notes on subscription fees
1 parent 72ee91d commit 16a5d59

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/contracts/facilitators/gsm/converter/GsmConverter.sol

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ contract GsmConverter is Ownable, EIP712, IGsmConverter {
235235
IERC20(REDEEMED_ASSET).approve(SUBSCRIPTION_CONTRACT, redeemedAssetAmount);
236236
//TODO: replace with proper issuance implementation later
237237
MockBUIDLSubscription(SUBSCRIPTION_CONTRACT).issuance(redeemedAssetAmount);
238+
// TODO: probably will be fees from issuance, so need to adjust the logic
238239
require(
239240
IERC20(ISSUED_ASSET).balanceOf(address(this)) ==
240241
initialissuedAssetBalance + redeemedAssetAmount,
@@ -243,6 +244,7 @@ contract GsmConverter is Ownable, EIP712, IGsmConverter {
243244
// reset approval after issuance
244245
IERC20(REDEEMED_ASSET).approve(SUBSCRIPTION_CONTRACT, 0);
245246

247+
// TODO: account for fees for sellAsset amount param
246248
IERC20(ISSUED_ASSET).approve(GSM, redeemedAssetAmount);
247249
(uint256 assetAmount, uint256 ghoBought) = IGsm(GSM).sellAsset(maxAmount, receiver);
248250
// reset approval after sellAsset

0 commit comments

Comments
 (0)